Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] incorrect errors mapping for templates #224

Closed
lifeart opened this issue Oct 17, 2021 · 3 comments · Fixed by #247
Closed

[windows] incorrect errors mapping for templates #224

lifeart opened this issue Oct 17, 2021 · 3 comments · Fixed by #247

Comments

@lifeart
Copy link

lifeart commented Oct 17, 2021

image

@lifeart
Copy link
Author

lifeart commented Nov 3, 2021

Double checked results, and it's reproducible only for Windows environment, same error has correct highlighting in mac. Looks like it may be related to different newline delimiters.

Changing vscode newline setting does not solve problem.

@lifeart lifeart changed the title incorrect errors mapping for glimmerx component templates [Windows] incorrect errors mapping for templates Nov 3, 2021
@lifeart lifeart changed the title [Windows] incorrect errors mapping for templates [windows] incorrect errors mapping for templates Nov 3, 2021
@dfreeman
Copy link
Member

dfreeman commented Nov 5, 2021

Do you have a repo that can reproduce this? Our test suite (including some smoke tests that launch VS Code and verify diagnostic locations) runs in Windows in CI.

@lifeart
Copy link
Author

lifeart commented Nov 7, 2021

@dfreeman yes,

image

https://github.com/lifeart/glimmerx-workshop/tree/glint-issue

image

[uELS disabled, glint: enabled]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants