Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow typeahead bower install to succeed against jquery 2+ #898

Closed
wants to merge 1 commit into from

Conversation

wbbradley
Copy link

I don't see anything in typeahead that prevents its use on higher versions of jQuery.

I don't see anything in typeahead that prevents its use on higher versions of jQuery.
@wbbradley
Copy link
Author

Hmm... back to the drawing board.

@wbbradley wbbradley closed this Jul 13, 2014
@jharding
Copy link
Contributor

The unit test suite failed cause the location of the jQuery file in the 1.7 distribution is different from the location in 2.x distribution.

And you're correct, >= 1.7 should be the requirement.

@wbbradley
Copy link
Author

@jharding Do you have any quick pointers to how I might fix the issue you mentioned? I'm not super familiar with the config for this project.

@wbbradley wbbradley reopened this Jul 14, 2014
@cedrichan
Copy link

Is it not sufficient to revert commit 6dbc2be?

@cedrichan
Copy link

See #905

@jharding
Copy link
Contributor

I'm dumb. What I should have done is left "jquery": ">=1.7" as a dependency and then added "jquery": "~1.7" as a dev dependency.

@cedrichan
Copy link

Wouldn't that just install the latest jquery anyway, since it would install what's specified in dependencies over devDependencies?

@jharding
Copy link
Contributor

Wouldn't that just install the latest jquery anyway, since it would install what's specified in dependencies over devDependencies?

Based on what I know, devDependencies will get precedence over dependencies unless the --production flag is used during install.

@jharding jharding added this to the v0.10.5 milestone Jul 28, 2014
@jugglinmike
Copy link

@jharding I just tried to put together a new pull request based on your request. Unfortunately, it looks like Bower does not give precedence to devDependencies--when dependencies and devDependencies describe a Bower component at two different versions, Bower honors the version in dependencies.

I think a complete solution will entail more infrastructural work: the tests should run against all supported versions of jQuery. In the immediate term, though, it might make sense to merge gh-905 since this is causing problems for people today.

@jugglinmike
Copy link

@jharding Actually, I found a short-term solution that should make everyone happy: #924

@jharding
Copy link
Contributor

jharding commented Aug 7, 2014

@jharding I just tried to put together a new pull request based on your request. Unfortunately, it looks like Bower does not give precedence to devDependencies--when dependencies and devDependencies describe a Bower component at two different versions, Bower honors the version in dependencies.

Hmm, when I played around with it, bower was giving precedence to devDependencies. Can you try out #917 and let me know if that doesn't work for you?

@jugglinmike
Copy link

That branch seems to work fine. Not sure what I was doing differently, but I guess the implicit solution should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants