-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow typeahead bower install to succeed against jquery 2+ #898
Conversation
I don't see anything in typeahead that prevents its use on higher versions of jQuery.
Hmm... back to the drawing board. |
The unit test suite failed cause the location of the jQuery file in the 1.7 distribution is different from the location in 2.x distribution. And you're correct, >= 1.7 should be the requirement. |
@jharding Do you have any quick pointers to how I might fix the issue you mentioned? I'm not super familiar with the config for this project. |
Is it not sufficient to revert commit 6dbc2be? |
See #905 |
I'm dumb. What I should have done is left |
Wouldn't that just install the latest jquery anyway, since it would install what's specified in |
Based on what I know, |
@jharding I just tried to put together a new pull request based on your request. Unfortunately, it looks like Bower does not give precedence to I think a complete solution will entail more infrastructural work: the tests should run against all supported versions of jQuery. In the immediate term, though, it might make sense to merge gh-905 since this is causing problems for people today. |
Hmm, when I played around with it, bower was giving precedence to devDependencies. Can you try out #917 and let me know if that doesn't work for you? |
That branch seems to work fine. Not sure what I was doing differently, but I guess the implicit solution should be fine. |
I don't see anything in typeahead that prevents its use on higher versions of jQuery.