Skip to content

Commit

Permalink
Use jQuery v1.7 for development.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jake Harding committed Jul 9, 2014
1 parent 0db49bc commit 6dbc2be
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
"version": "0.10.2",
"main": "dist/typeahead.bundle.js",
"dependencies": {
"jquery": ">=1.7"
"jquery": "~1.7"
},
"devDependencies": {
"jasmine-ajax": "~1.3.1",
"jasmine-jquery": "~1.5.2"
}
}
}
2 changes: 1 addition & 1 deletion karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ preprocessors = {

// list of files / patterns to load in the browser
files = [
'bower_components/jquery/dist/jquery.js',
'bower_components/jquery/jquery.js',
'src/common/utils.js',
'src/bloodhound/version.js',
'src/bloodhound/tokenizers.js',
Expand Down
2 changes: 1 addition & 1 deletion test/playground.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<head>
<script src="../bower_components/jquery/dist/jquery.js"></script>
<script src="../bower_components/jquery/jquery.js"></script>
<script src="../dist/typeahead.bundle.js"></script>

<style>
Expand Down

4 comments on commit 6dbc2be

@wbbradley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will bower install jquery 1.7 into that parent directory?

@jayclassless
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bower will install jQuery, but since the version range has changed to ~, it will only work with jQuery v1.7.*, which is a rather strict requirement and is causing me some headaches.

Any chance we can put that back to >=1.7?

@baer
Copy link

@baer baer commented on 6dbc2be Aug 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jQuery 1.7 came out in march of 2012 why is this pinned to such an old version of the library?

@jharding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry, this was a mistake by me. I'll fix it for v0.10.5.

Please sign in to comment.