fix stats segfault issue #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to have a regression test? |
|
I talked with @thinkingfish about this. I would like to add unit tests for the admin protocol; however, I have been unable to be thorough with them because of the problem I talk about in my comment on issue #49. Because this is on the admin plane and not the data plane, we are not too worried about moving forward for now to get a production ready package, until we migrate to statsd, when we will refactor metrics and add more admin related unit tests. |
|
🚢 |
TomekIdczak97
pushed a commit
to TomekIdczak97/pelikan
that referenced
this pull request
Sep 3, 2019
Add pmem test scenario for ungraceful shutdown
swlynch99
pushed a commit
to swlynch99/pelikan-twitter
that referenced
this pull request
Sep 30, 2019
make metric_print threadsafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"next" member in struct reply was not getting reset, which caused chained replies to segfault.