Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add admin-protocol related unit test #49

Open
thinkingfish opened this issue Nov 26, 2015 · 1 comment
Open

add admin-protocol related unit test #49

thinkingfish opened this issue Nov 26, 2015 · 1 comment
Assignees

Comments

@thinkingfish
Copy link
Contributor

No description provided.

@kevyang
Copy link
Contributor

kevyang commented Dec 5, 2015

Currently working on adding the second set of admin protocol unit tests, and I have run into a roadblock. To write these unit tests, we need to write parse_reply; currently struct reply does not lend itself well to being parsed because we cannot really go from a composed "stats" response to struct metric * (since it is ambiguous whether a metric is a gauge or a counter) and since we use a pointer to where the metric is being kept, and it doesn't make sense to create a new struct metric when parsing a reply, since the struct metric we create would not be part of any overlying array of struct metric. We could refactor admin/reply to be more similar to how the original struct response in the memcache module worked with stats, but I think the current solution for struct reply is simpler if we only need to compose replies instead of parse them as well. Any thoughts?

michalbiesek added a commit to michalbiesek/pelikan that referenced this issue Jul 25, 2019
swlynch99 pushed a commit to swlynch99/pelikan-twitter that referenced this issue Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants