Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING feat: add support for custom HTTP headers in API requests #499

Merged
merged 16 commits into from
Nov 14, 2019
Merged

BREAKING feat: add support for custom HTTP headers in API requests #499

merged 16 commits into from
Nov 14, 2019

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Nov 6, 2019 •
edited
Loading

Fixes #466
Fixes #458

@childish-sambino childish-sambino changed the title added support for custom HTTP headers in API requests feat: add support for custom HTTP headers in API requests Nov 6, 2019
childish-sambino
childish-sambino reviewed Nov 6, 2019
View reviewed changes
lib/rest/authy/v1/service.d.ts Show resolved Hide resolved
lib/rest/authy/v1/service.d.ts Outdated Show resolved Hide resolved
lib/rest/chat/v2/service/channel.d.ts Outdated Show resolved Hide resolved
lib/rest/ipMessaging/v2/service/user.js Outdated Show resolved Hide resolved
lib/rest/preview/sync/service/document.d.ts Outdated Show resolved Hide resolved
lib/rest/preview/trusted_comms/cps.js Show resolved Hide resolved
lib/rest/preview/trusted_comms/currentCall.js Show resolved Hide resolved
lib/rest/preview/sync/service/syncList/syncListItem.js Outdated Show resolved Hide resolved
@eshanholtz eshanholtz changed the title feat: add support for custom HTTP headers in API requests BREAKING feat: add support for custom HTTP headers in API requests Nov 6, 2019
childish-sambino
childish-sambino approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

spec/integration/rest/authy/v1/service.spec.js Outdated Show resolved Hide resolved
@eshanholtz eshanholtz merged commit c5ad2d7 into master Nov 14, 2019
@eshanholtz eshanholtz deleted the support-if-match branch November 14, 2019 18:22
@snyk-bot snyk-bot mentioned this pull request Jan 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2020
Open
@childish-sambino childish-sambino mentioned this pull request Jul 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Map Mutate Adding Custom Headers Property
3 participants
@eshanholtz @childish-sambino @twilio-ci