PhoneNumberType/Carrier not defined correctly in typescript def

[psaia]

Main issues:

• It looks like PhoneNumberType is never used or exported.
• The carrier property is defined as a string when it's in fact an object. I imagine the type property within that object should get the type PhoneNumberType.

Example:

const res = await twilioClient.lookups.phoneNumbers("some phone number").fetch({
  type: ["carrier"] // Also FYI, in the docs this is shown as a string instead of string[]
});

console.log(res.carrier); // => {mobile_country_code, mobile_network_code, name, type, error_code}

So maybe a new struct is needed to represent the carrier:

interface Carrier {
  mobile_country_code: string;
  mobile_network_code: string;
  name: string;
  type: PhoneNumberType;
  error_code: number | null; // ?
}

[childish-sambino]

Looks like the definition this is generated from is not complete and is missing the structure definition for both carrier and caller_name. Keeping this issue open as part of the backlog.

Regarding type: ["carrier"] showing as type string, I'm seeing this as fixed in the docs back in late 2016.

[childish-sambino]

PhoneNumberType added to exports as part of #499 (source)

[childish-sambino]

Moving this to an enhancement request. Since this is generated code, adding a new nested type declaration is not currently supported.

This issue has been added to our internal backlog to be prioritized. +1s (👍 ) on the issue summary will help it move up the backlog.

[manisha1997]

Seems like this issue is resolved at the latest version.
Can you please review and comment?