Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix poetry in CI #330

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Fix poetry in CI #330

merged 2 commits into from
Oct 8, 2021

Conversation

GuillaumeDesforges
Copy link
Contributor

  • Fix poetry in nix-shell to poetry 1.1.10
  • Rewrite lockfiles

@GuillaumeDesforges
Fix poetry in CI
9ea8fb2 
* Fix poetry in nix-shell to poetry 1.1.10
* Rewrite lockfiles
@GuillaumeDesforges GuillaumeDesforges self-assigned this Oct 6, 2021
@GuillaumeDesforges GuillaumeDesforges marked this pull request as draft October 6, 2021 15:15
@GuillaumeDesforges GuillaumeDesforges marked this pull request as ready for review October 6, 2021 15:26
@GuillaumeDesforges GuillaumeDesforges mentioned this pull request Oct 6, 2021
Closed
simeoncarstens
simeoncarstens reviewed Oct 6, 2021
View reviewed changes
Copy link
Member

@simeoncarstens simeoncarstens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉 looks good to me, but I'm a bit shy about bumping the nixpkgs version, see my comment on the corresponding line. I'd rather wait for additional feedback by the other Chainsailers before merging.

nix/sources.json
"url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz"
},
"nixpkgs": {
"branch": "nixos-20.09",
"branch": "nixos-21.05",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major change - maybe we should test whether everything works when deployed, too, given that we currently don't have integration tests? 🤔

@Etjean Etjean linked an issue Oct 7, 2021 that may be closed by this pull request
CI fails with Poetry error #321
Closed
@GuillaumeDesforges GuillaumeDesforges merged commit 6719e00 into main Oct 8, 2021
@GuillaumeDesforges GuillaumeDesforges deleted the fix-ci-poetry-gd branch October 8, 2021 14:02
@GuillaumeDesforges GuillaumeDesforges mentioned this pull request Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeoncarstens simeoncarstens simeoncarstens left review comments

Assignees

@GuillaumeDesforges GuillaumeDesforges

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails with Poetry error
2 participants
@GuillaumeDesforges @simeoncarstens