Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pipeline #323

Closed
wants to merge 5 commits into from
Closed

Fix CI pipeline #323

wants to merge 5 commits into from

Conversation

Etjean
Copy link
Contributor

@Etjean Etjean commented Oct 4, 2021

From #321

@Etjean Etjean changed the title Upgrade CI poetry to 1.1.10 Fix CI pipeline Oct 4, 2021
@Etjean Etjean marked this pull request as draft October 4, 2021 09:36
@Etjean Etjean linked an issue Oct 4, 2021 that may be closed by this pull request
@Etjean Etjean marked this pull request as ready for review October 4, 2021 12:33
@Etjean
Copy link
Contributor Author

Etjean commented Oct 4, 2021

  • Updated to poetry 1.1.10
  • Had to remove the lockfile from the controller before installing, otherwise failing with Directory ../grpc does not exist

@simeoncarstens
Copy link
Member

Had to remove the lockfile from the controller before installing, otherwise failing with Directory ../grpc does not exist

I guess this is not a permanent solution and I'm very surprised that this doesn't break stuff. So looks like this relative import bug is still not fixed in Poetry 🤔

@GuillaumeDesforges
Copy link
Contributor

GuillaumeDesforges commented Oct 6, 2021

I could reproduce the issue locally, this diff seemed to fix it for me

diff --git a/app/controller/poetry.lock b/app/controller/poetry.lock
index dc54a32..e09039f 100644
--- a/app/controller/poetry.lock
+++ b/app/controller/poetry.lock
@@ -99,11 +99,11 @@ description = "Chainsail code shared between components"
 category = "main"
 optional = false
 python-versions = "^3.8"
-develop = false
+develop = true
 
 [package.dependencies]
 apache-libcloud = ">=3.3.1,<4.0.0"
-chainsail-grpc = "0.1.0"
+chainsail-grpc = {path = "../grpc", develop = true}
 cryptography = ">=3.4.1,<4.0.0"
 marshmallow = ">=3.10.0,<4.0.0"
 marshmallow-enum = ">=1.5.1,<2.0.0"

using Poetry version 1.1.10

@GuillaumeDesforges
Copy link
Contributor

Seems I could fix the CI without removing the lockfile #330

@Etjean Etjean closed this Oct 11, 2021
@Etjean Etjean deleted the etienne/fix-CI-poetry branch October 11, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails with Poetry error
3 participants