Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .active navbar breaking change to 5.0 docs #36516

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Add .active navbar breaking change to 5.0 docs #36516

merged 1 commit into from
Jun 8, 2022

Conversation

jhthompson
Copy link
Contributor

Closes #36514

@mdo
Copy link
Member

mdo commented Jun 6, 2022

This is probably something we should fix instead of documenting the breaking change. I don't recall if this was intentional or not. Any thoughts @twbs/css-review?

@jhthompson
Copy link
Contributor Author

This is probably something we should fix instead of documenting the breaking change. I don't recall if this was intentional or not. Any thoughts @twbs/css-review?

@mdo it looks like this was intentional (or at least was an idea at one point): #30652 (comment)

@mdo
Copy link
Member

mdo commented Jun 8, 2022

Hah, typical—I forget what I did myself haha. Thanks!

@mdo mdo merged commit 0a38646 into twbs:main Jun 8, 2022
@jhthompson jhthompson deleted the active-navbar-docs branch June 9, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Include ".active" navbar breaking change in v5 migration docs
3 participants