-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ".active" navbar breaking change in v5 migration docs #36514
Comments
(oops, accidentally added with |
Thanks for opening an issue @jhthompson :)
You can create a branch against our main branch and modify migration.md. |
Sounds good! IMO it really should be applied to the 5.0 migration guide as it is broken at that version, but if there's no way to update the already shipped migration guide then adding it to the latest 5.x documentation is the next best thing. |
Ahh I see that the new migrations docs are for all of 5.x, not just >5.0. I think this is the appropriate place to add this then. |
Prerequisites
Proposal
.nav-item
to.nav-link
#32730Motivation and context
Navbar breaking change1 was not listed in the v5 migration docs under the navbar section. It would nice to have it listed for easier migration as I almost missed this breaking change. Other related doc fixes23
Footnotes
https://github.com/twbs/bootstrap/pull/32730 ↩
https://github.com/twbs/bootstrap/pull/32589 ↩
https://github.com/twbs/bootstrap/issues/32583 ↩
The text was updated successfully, but these errors were encountered: