Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ".active" navbar breaking change in v5 migration docs #36514

Closed
2 tasks done
jhthompson opened this issue Jun 6, 2022 · 4 comments · Fixed by #36516
Closed
2 tasks done

Include ".active" navbar breaking change in v5 migration docs #36514

jhthompson opened this issue Jun 6, 2022 · 4 comments · Fixed by #36516

Comments

@jhthompson
Copy link
Contributor

Prerequisites

Proposal

Motivation and context

Navbar breaking change1 was not listed in the v5 migration docs under the navbar section. It would nice to have it listed for easier migration as I almost missed this breaking change. Other related doc fixes23

Footnotes

  1. https://github.com/twbs/bootstrap/pull/32730

  2. https://github.com/twbs/bootstrap/pull/32589

  3. https://github.com/twbs/bootstrap/issues/32583

@jhthompson
Copy link
Contributor Author

jhthompson commented Jun 6, 2022

(oops, accidentally added with feature label, should be docs instead)

@julien-deramond
Copy link
Member

Thanks for opening an issue @jhthompson :)

I am willing to open a PR to fix, but could not find source file to edit (is there a v5.0 branch to make the PR against?)

You can create a branch against our main branch and modify migration.md.
If the modification is approved/merged, the latest version of the 5.x documentation will contain your modification in "Migrating to v5".
However I'm not sure if we will be able to modify as well the already shipped migration guide for 5.1 and 5.0.

@jhthompson
Copy link
Contributor Author

Thanks for opening an issue @jhthompson :)

I am willing to open a PR to fix, but could not find source file to edit (is there a v5.0 branch to make the PR against?)

You can create a branch against our main branch and modify migration.md. If the modification is approved/merged, the latest version of the 5.x documentation will contain your modification in "Migrating to v5". However I'm not sure if we will be able to modify as well the already shipped migration guide for 5.1 and 5.0.

Sounds good! IMO it really should be applied to the 5.0 migration guide as it is broken at that version, but if there's no way to update the already shipped migration guide then adding it to the latest 5.x documentation is the next best thing.

@jhthompson
Copy link
Contributor Author

jhthompson commented Jun 6, 2022

Ahh I see that the new migrations docs are for all of 5.x, not just >5.0. I think this is the appropriate place to add this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants