-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix width and height of data svg images in IE10 #28883
Conversation
If this lands it needs to target master and also make sure all other SVGs don't have this issue. |
Changed the target branch so that it can't be merged blindly. See my message above. |
Switched this to v4-dev-xmr. But yeah, master is moot indeed. |
I'd still appreciate someone checking the other inline SVGs, because IIRC we don't use width/height. |
@XhmikosR I'll check them today |
Going to make a note of this for my v5 forms branch at #28450 to at least confirm sizing works in IE11+, Edge, etc as I'm intending. |
Only IE10 seems to have this is issue afaik. |
Yeah, it just reminded me that I don't recall if there are any major hiccups and we're going all in on custom forms in v5. With new SVGs, I want to make sure I'm keeping things in mind and can document known issues to help folks customize. |
dd2edd6
to
9c2f144
Compare
Searched entire project, only variables.scss has such inline SVG images. Pull request updated. |
@twbs/css-review: can you review one final time please? |
This comment has been minimized.
This comment has been minimized.
9c2f144
to
9305099
Compare
Inline svg of custom-select is broken in IE10 because there is no width and height attributes.
Tested on a real IE10 in browserstack, it works.