v5: Forms update #28450
Merged
v5: Forms update #28450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2019
XhmikosR
force-pushed
the
v5-forms-spike
branch
from
1e25969
to
746feb4
Compare
XhmikosR
reviewed
Mar 14, 2019
| @@ -163,6 +163,93 @@ Set horizontally scrollable range inputs using `.form-control-range`. | |||
|
|
|||
| ## Checkboxes and radios | |||
|
|
|||
| <script> | |||
There was a problem hiding this comment.
Note that this should go in application.js and without the DOMContentLoaded.
- Prepping to drop non-custom file and range inputs - Prepping to merge custom and native checks and radios (with switches) - Prepping to merge custom select with form select - Moving docs arround so forms has it's own area given volume of CSS
XhmikosR
force-pushed
the
v5-forms-spike
branch
from
74e002a
to
c47356b
Compare
|
Just marked this ready for review solely could I see the diff and conflicts here in the PR. Will try to resolve those soon. |
This was referenced Jul 13, 2019
patrickhlauke
pushed a commit
that referenced
this pull request
Jul 13, 2019
* Initial spike of consolidated form checks * Stub out forms rearrangement - Prepping to drop non-custom file and range inputs - Prepping to merge custom and native checks and radios (with switches) - Prepping to merge custom select with form select - Moving docs arround so forms has it's own area given volume of CSS * Move input group Sass file to forms subdir * Start to split and move the docs around * Simpler imports * Copyediting * delete overview file * Remove commented out code * remove the custom-forms import * rewrite flex-check as form-check, replace all custom properties * Remove old forms doc * stub out new subpage link section * update migration guide * Update nav, forms overview in page nav, and descriptions * fix check bg position * fix margin-top calculation * rename .custom-select to .form-select * Update validation styles for new checks * add some vertical margin, fix inline checks * fix docs examples * better way to do this contents stuff, redo the toc while i'm at it * page restyle for docs while here * un-callout that, edit text * redo padding on toc * fix toc * start to cleanup checks docs * Rewrite Markdown tables into HTML * Redesign tables, redo their docs * Replace Open Iconic icons with custom Bootstrap icons * Redesign the docs navbar, add a subheader, redo the sidebar * Redesign docs homepage a bit * Simplify table style overrides for docs tables * Simplify docs typography for page titles and reading line length * Stub out icons page * Part of sidebar update, remove migration from nav.yml * Move toc CSS to separate partial * Change appearance of overview page * fix sidebar arrow direction * Add footer to docs layout * Update descriptions * Drop the .form-group class for margin utilities * Remove lingering form-group-margin-bottom var * improve footer spacing * add headings to range page * uncomment form range css * Rename .custom-range to .form-range * Drop unused docs var * Uncomment the comment * Remove unused variable * Fix radio image sizing * Reboot update: reset horizontal ul and ol padding * de-dupe IDs * tweak toc styles * nvm, fix dropdown versions stuff * remove sidebar nav toggle for now * broken html * fix more broken html, move css * scss linting * comment out broken helper docs * scope styles * scope styles * Fixes #25540 and fixes #26407 for v5 only * Update sidebar once more * Match new sidenav order * fix syntax error * Rename custom-file to form-file, update paths, update migration docs for previous changes in #28696 * rename back * fix size and alignment * rename that back too
XhmikosR
pushed a commit
that referenced
this pull request
Jul 14, 2019
|
12 tasks
This was referenced Sep 26, 2019
Closed
|
@mdo Why do the new form components not have transitions/motion? Is there a way to re-enable them? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on some relatively major form changes:
/components/formsto/forms/components/input-groupto/forms/input-group/formsinto subpages.form-check, etc.form-select.form-control-fileand.form-control-range.form-groupfor a margin utility?Probably want to wait to get Hugo stuff merged before continuing on. I imagine when I start to move the docs around there will be hella conflicts.
Demo: https://deploy-preview-28450--twbs-bootstrap.netlify.com/docs/4.3/forms/overview/