v5: Drop remaining deprecated mixins #28461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
v5-drop-remaining-mixins
branch
from
5705526
to
f6e8bee
Compare
|
We should also update the docs. I think we better drop these mixins after we've merged the Hugo branch to avoid too many conflicts. |
|
There shouldn't be too many doc changes here, only the text-hide page removal page and the nav update which I can rebase. But yeah, we need to move forward because I have rebased it like 150 times already. |
|
Agreed, I'm waiting on any meaningful docs changes until after Hugo merges. I have plenty coming per our v5 plans issue in the team repo. |
13 tasks
XhmikosR
force-pushed
the
v5-drop-remaining-mixins
branch
from
f6e8bee
to
fe8898f
Compare
- Deletes mixin mentions from float docs - Deletes mixin mention from visibility docs - Deletes the image-replacement page for text-hide
|
Pushed updated docs, so this is ready for review. |
MartijnCuppens
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't realize we had this many deprecated mixins to drop. See also #28459 and #28460. The
.form-control-focusmixin is being removed in #28450.