Fix #23209. remove line height from input type number #23227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 6, 2017
scss/_forms.scss
Outdated
|
|
||
| // line height issue in input type number. Solve by not assiging line height in inuput number type. | ||
| &:not([type="number"]){ | ||
| line-height: $input-btn-line-height; |
There was a problem hiding this comment.
Line should be indented with spaces, not tabs
scss/_forms.scss
Outdated
| color: $input-color; | ||
| background-color: $input-bg; | ||
| // Reset unusual Firefox-on-Android default style; see https://github.com/necolas/normalize.css/issues/214. | ||
| background-image: none; | ||
| background-clip: padding-box; | ||
| border: $input-btn-border-width solid $input-border-color; | ||
|
|
||
| // line height issue in input type number. Solve by not assiging line height in inuput number type. | ||
| &:not([type="number"]){ |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
houndci-bot
reviewed
Aug 6, 2017
scss/_forms.scss
Outdated
|
|
||
| // line height issue in input type number. Solve by not assiging line height in inuput number type. | ||
| &:not([type="number"]) { | ||
| line-height: $input-btn-line-height; |
There was a problem hiding this comment.
Line should be indented 4 spaces, but was indented 3 spaces
|
Given this affects more than the number inputs, closing out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issue mention in #23209. There is line height issue only in input type number. I have remove line height from number type by adding this css code
&:not([type="number"]){ line-height: $input-btn-line-height; }