Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input[type=number] placeholder clipped in Firefox #23209

Closed
judowalker opened this issue Aug 2, 2017 · 18 comments
Closed

input[type=number] placeholder clipped in Firefox #23209

judowalker opened this issue Aug 2, 2017 · 18 comments

Comments

@judowalker
Copy link

The placeholder is clipped in an input of type number in Firefox on Windows 10. This only happens with a class of form-control.

Minimal working example with latest dev:
https://codepen.io/anon/pen/NvRpgJ

@XhmikosR
Copy link
Member

XhmikosR commented Aug 3, 2017

Works fine with Bootstrap v4.alpha-6: https://codepen.io/anon/pen/oezpKq

@judowalker
Copy link
Author

I'm using the latest from v4-dev, not the cdn.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 3, 2017 via email

@XhmikosR
Copy link
Member

XhmikosR commented Aug 3, 2017

OK, confirmed: https://codepen.io/anon/pen/MvjXYj

/CC @mdo: did something change markup-wise or is the markup used fine?

@Miguel-Serejo
Copy link

I played around a bit with your demo and it looks like increasing line-height from 1.25 to anything over 1.39948 will fix it.
It's weird because it's not a progressive thing, it's fully clipped at 1.39947 and fully visible at 1.39948.

@mdo
Copy link
Member

mdo commented Aug 10, 2017

I don't see the issue in Firefox 53 on macOS.

@XhmikosR
Copy link
Member

I definitely see it on Windows with FF 55 and 56 with the codepen I pasted above which is using the latest v4-dev version.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 10, 2017

For me, it gets fixed with >= 1.381. I believe it's due to the font being used on Windows; Segoe UI. If I switch the font to Arial, it's OK with 1.25.

IE 11 and Edge work fine on the same Windows system.

@XhmikosR
Copy link
Member

Hmm, I just noticed. The pen above doesn't include <meta name="viewport" content="width=device-width, initial-scale=1">. After adding that it is fine. Also, the inputs are of type number yet their placeholder was text in the original codepen.

So I believe this is a non issue after all. See https://codepen.io/XhmikosR/pen/zdzvad

@XhmikosR
Copy link
Member

XhmikosR commented Aug 11, 2017

If that's the case we should also close #23227 too.

/CC @Johann-S

@judowalker
Copy link
Author

@XhmikosR your example is not showing the bootstrap styles because it has a console error:

Refused to execute script from 'https://github.com/twbs/bootstrap/raw/v4-dev/dist/js/bootstrap.min.js' because its MIME type ('text/plain') is not executable, and strict MIME type checking is enabled.

It also doesn't have a placeholder.
It also doesn't include <meta name="viewport" content="width=device-width, initial-scale=1"> which you stated fixes the issue.

Also, the inputs are of type number yet their placeholder was text in the original codepen.

I don't understand what you are saying here. Why can't a placeholder be text?

@XhmikosR
Copy link
Member

Please check the codepen above. I'm still not sure your codepen is right or not and I don't have the time to investigate this more.

Someone else will have to have a look.

@judowalker
Copy link
Author

That's the one I checked. See the screenshot below. It doesn't even have a placeholder and there's no Bootstrap styling.
image

@mdo
Copy link
Member

mdo commented Aug 12, 2017

Appears other input types have issues, too, with Firefox. See #23355

@chiraggmodi
Copy link
Contributor

@mdo don't see this issue any other input type. its appear only in number type.

@QuantumHive
Copy link

Can confirm this for Windows 10, Firefox 55:
capture

No problems in Windows 10, Chrome 60:
capture

@krzysztofjeziorny
Copy link

Also clipped in Firefox 55/Linux. Setting the line-hight to 1.35 in $input-btn-line-height fixes it.
Screenshots: #23347 (comment)

@mdo
Copy link
Member

mdo commented Aug 29, 2017

Consolidating issues; closing for #23347.

@mdo mdo closed this as completed Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants