Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs fixes #14941

Closed
wants to merge 2 commits into from
Closed

Docs fixes #14941

wants to merge 2 commits into from

Conversation

hillai
Copy link
Contributor

@hillai hillai commented Oct 30, 2014

@cvrebert cvrebert added the docs label Oct 30, 2014
@cvrebert cvrebert added this to the v3.3.1 milestone Oct 30, 2014
cvrebert
cvrebert reviewed Oct 30, 2014
View reviewed changes
docs/_includes/getting-started/template.html
@@ -27,7 +27,7 @@ <h1 id="template" class="page-header">Basic template</h1>
<h1>Hello, world!</h1>

<!-- jQuery (necessary for Bootstrap's JavaScript plugins) -->
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still support IE 8, so we need to stick with jQuery 1.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but wouldn't that throw an error according to #14852?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. #14852 enforces jQuery>=1.9.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I'm missing something here :(
1.11.1 isn't really >=1.9.1. Shouldn't the template still be changed to 1.9.1?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 > 9
1.11.1 is greater than 1.9.1 when compared via SemVer, which #14852 basically does.
jQuery 1.9.1 is the minimum required version, but unless there's a jQuery-version-related bug in another library someone is using, there's no reason not to use to the latest 1.x jQuery, which is 1.11.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for clarifiying!

@cvrebert cvrebert closed this in 1339ab7 Oct 30, 2014
cvrebert added a commit that referenced this pull request Oct 30, 2014
@cvrebert
Port #14941 over to hosted docs
d3085c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@hillai @mdo @cvrebert