Add jQuery version check to existing jQuery presence check #14852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrch02
force-pushed
the
jquery-version-check
branch
from
060f78b to
4956ee3
Compare
| '+function ($) {', | ||
| ' var versionString = $.fn.jquery.split(\' \')[0]', | ||
| ' var version = versionString.match(/(\\d+)(?=\\.?)/g)', | ||
| ' if ((version[0] < 2 && version[1] < 9) || /1\\.9\\.0rc1|1\\.9\\.0b1/.test(versionString)) {', |
There was a problem hiding this comment.
Perhaps we could bump the minimum jQuery to 1.9.1 to avoid the RC/Beta complications?
hnrch02
force-pushed
the
jquery-version-check
branch
from
4956ee3 to
c6c6dc2
Compare
|
@cvrebert Is that better? |
|
Yes. I believe we could also simplify the regex to just split on dots? |
hnrch02
force-pushed
the
jquery-version-check
branch
from
c6c6dc2 to
1604af0
Compare
|
I believe this is as good as it gets 😄 |
|
Very nearly. 😄 Why is the |
|
Because of custom builds, see for example GitHub's jQuery build. It identifies itself with |
|
LGTM then. |
|
Travis failure is unrelated. |
hnrch02
added a commit
that referenced
this pull request
Oct 23, 2014
Add jQuery version check to existing jQuery presence check
|
@cvrebert Should I add a ship list entry for this? |
|
Yup! |
|
I'm not sure about the section, would you mind adding it for me? 😁 |
|
Sure. |
|
Merci beaucoup. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14809.
Closes #14825.
/cc @cvrebert