Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offcanvas transition on mobile is wonky #36347

Closed
3 tasks done
mdo opened this issue May 13, 2022 · 4 comments · Fixed by #36353
Closed
3 tasks done

Offcanvas transition on mobile is wonky #36347

mdo opened this issue May 13, 2022 · 4 comments · Fixed by #36353

Comments

@mdo
Copy link
Member

mdo commented May 13, 2022

Prerequisites

Describe the issue

When opening offcanvas menus on the docs when on a phone or narrow viewport, the transition is a little wonky. It looks like the backdrop is fading in first and then the drawer is coming in. What should happen is the fade and draw happen at the same time.

Reduced test cases

https://getbootstrap.com

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Safari

What version of Bootstrap are you using?

v5.2.0-beta1

@mdo
Copy link
Member Author

mdo commented May 13, 2022

/cc @GeoSot @XhmikosR

@XhmikosR
Copy link
Member

XhmikosR commented May 13, 2022

Confirmed I see it on Windows 10 with Firefox. It's like the backdrop fires up immediately but the offcanvas hasn't finished transitioning.

EDIT: not sure if it's a regression or it was like that since the beginning.

@justinkruit
Copy link
Contributor

Noticing the same on Chrome on Android.

@nalakapws
Copy link
Contributor

Yeah! it's slow.

justinkruit added a commit to justinkruit/bootstrap that referenced this issue May 14, 2022
The transform of .showing was being overridden by .offcanvas.offcanvas-start, while .show wasn't. This resulted in an illusion of the offcanvas waiting for the backdrop, reported in twbs#36347. Moving the show classes below the position classes fixes this problem.
XhmikosR pushed a commit that referenced this issue May 14, 2022
The transform of .showing was being overridden by .offcanvas.offcanvas-start, while .show wasn't. This resulted in an illusion of the offcanvas waiting for the backdrop, reported in #36347. Moving the show classes below the position classes fixes this problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants