Skip to content

Commit

Permalink
Offcanvas not showing with .showing
Browse files Browse the repository at this point in the history
The transform of .showing was being overridden by .offcanvas.offcanvas-start, while .show wasn't. This resulted in an illusion of the offcanvas waiting for the backdrop, reported in twbs#36347. Moving the show classes below the position classes fixes this problem.
  • Loading branch information
justinkruit committed May 14, 2022
1 parent 46bb9e7 commit 3538a41
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions scss/_offcanvas.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,6 @@
@include box-shadow(var(--#{$prefix}offcanvas-box-shadow));
@include transition(transform $offcanvas-transition-duration ease-in-out);

&.showing,
&.show:not(.hiding) {
transform: none;
}

&.showing,
&.hiding,
&.show {
visibility: visible;
}

&.offcanvas-start {
top: 0;
left: 0;
Expand Down Expand Up @@ -88,6 +77,17 @@
border-top: var(--#{$prefix}offcanvas-border-width) solid var(--#{$prefix}offcanvas-border-color);
transform: translateY(100%);
}

&.showing,
&.show:not(.hiding) {
transform: none;
}

&.showing,
&.hiding,
&.show {
visibility: visible;
}
}

@if not ($infix == "") {
Expand Down

0 comments on commit 3538a41

Please sign in to comment.