Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Warns about pull-* classes in media #153

Closed
wants to merge 2 commits into from
Closed

Warns about pull-* classes in media #153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321c772
Warns about pull-* classes in media
iamphill Oct 30, 2014
e2216a5
Updates to error message & selector
Oct 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dist/browser/bootlint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11043,6 +11043,12 @@ var semver = require('semver');
reporter('Neither .form-inline nor .form-horizontal should be used directly on a `.form-group`. Instead, nest the .form-group within the .form-inline or .form-horizontal', badFormGroups);
}
});
addLinter("W010", function lintMediaPulls($, reporter) {
var mediaPulls = $('.media').children('.pull-left, .pull-right');
if (mediaPulls.length) {
reporter('Using `pull-left` or `pull-right` as part of media component is deprecated. Please use `media-left` or `media-right`.', mediaPulls);
}
});

exports._lint = function ($, reporter, disabledIdList) {
var disabledIdSet = {};
Expand Down
6 changes: 6 additions & 0 deletions src/bootlint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,12 @@ var semver = require('semver');
reporter('Neither .form-inline nor .form-horizontal should be used directly on a `.form-group`. Instead, nest the .form-group within the .form-inline or .form-horizontal', badFormGroups);
}
});
addLinter("W010", function lintMediaPulls($, reporter) {
var mediaPulls = $('.media').children('.pull-left, .pull-right');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use $('.media>.pull-left, .media>.pull-right')

if (mediaPulls.length) {
reporter('Using `pull-left` or `pull-right` as part of media component is deprecated. Please use `media-left` or `media-right`.', mediaPulls);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"is deprecated as of Bootstrap v3.3.0"

}
});

exports._lint = function ($, reporter, disabledIdList) {
var disabledIdSet = {};
Expand Down
13 changes: 13 additions & 0 deletions test/bootlint_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,5 +540,18 @@ exports.bootlint = {
'should complain when alert close button is not first child in alert.'
);
test.done();
},

'pull classes inside media': function (test) {
test.expect(2);
test.deepEqual(lintHtml(utf8Fixture('media/pull-classes.html')),
['Using `pull-left` or `pull-right` as part of media component is deprecated. Please use `media-left` or `media-right`.'],
'should complain about pull classes inside media'
);
test.deepEqual(lintHtml(utf8Fixture('media/media-classes.html')),
[],
'should not complain about media pull classes'
);
test.done();
}
};
39 changes: 39 additions & 0 deletions test/fixtures/media/media-classes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<title>Test</title>
<!--[if lt IE 9]>
<script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></script>
<script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
<![endif]-->
<script src="../../lib/jquery.min.js"></script>

<link rel="stylesheet" href="../../lib/qunit.css">
<script src="../../lib/qunit.js"></script>
<script src="../../../dist/browser/bootlint.js"></script>
<script src="../generic-qunit.js"></script>
</head>
<body>
<div class="media">
<a class="media-left" href="#">
<img src="data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9InllcyI/PjxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB3aWR0aD0iNjQiIGhlaWdodD0iNjQiIHZpZXdCb3g9IjAgMCA2NCA2NCIgcHJlc2VydmVBc3BlY3RSYXRpbz0ibm9uZSI+PGRlZnMvPjxyZWN0IHdpZHRoPSI2NCIgaGVpZ2h0PSI2NCIgZmlsbD0iI0VFRUVFRSIvPjxnPjx0ZXh0IHg9IjE0LjUiIHk9IjMyIiBzdHlsZT0iZmlsbDojQUFBQUFBO2ZvbnQtd2VpZ2h0OmJvbGQ7Zm9udC1mYW1pbHk6QXJpYWwsIEhlbHZldGljYSwgT3BlbiBTYW5zLCBzYW5zLXNlcmlmLCBtb25vc3BhY2U7Zm9udC1zaXplOjEwcHQ7ZG9taW5hbnQtYmFzZWxpbmU6Y2VudHJhbCI+NjR4NjQ8L3RleHQ+PC9nPjwvc3ZnPg==" />
</a>
<div class="media-body">
<h4 class="media-heading">Media heading</h4>
</div>
</div>
<div class="media">
<a class="media-right" href="#">
<img src="data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9InllcyI/PjxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB3aWR0aD0iNjQiIGhlaWdodD0iNjQiIHZpZXdCb3g9IjAgMCA2NCA2NCIgcHJlc2VydmVBc3BlY3RSYXRpbz0ibm9uZSI+PGRlZnMvPjxyZWN0IHdpZHRoPSI2NCIgaGVpZ2h0PSI2NCIgZmlsbD0iI0VFRUVFRSIvPjxnPjx0ZXh0IHg9IjE0LjUiIHk9IjMyIiBzdHlsZT0iZmlsbDojQUFBQUFBO2ZvbnQtd2VpZ2h0OmJvbGQ7Zm9udC1mYW1pbHk6QXJpYWwsIEhlbHZldGljYSwgT3BlbiBTYW5zLCBzYW5zLXNlcmlmLCBtb25vc3BhY2U7Zm9udC1zaXplOjEwcHQ7ZG9taW5hbnQtYmFzZWxpbmU6Y2VudHJhbCI+NjR4NjQ8L3RleHQ+PC9nPjwvc3ZnPg==" />
</a>
<div class="media-body">
<h4 class="media-heading">Media heading</h4>
</div>
</div>
<div id="qunit"></div>
<ol id="bootlint"></ol>
</body>
</html>
33 changes: 33 additions & 0 deletions test/fixtures/media/pull-classes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<title>Test</title>
<!--[if lt IE 9]>
<script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></script>
<script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
<![endif]-->
<script src="../../lib/jquery.min.js"></script>

<link rel="stylesheet" href="../../lib/qunit.css">
<script src="../../lib/qunit.js"></script>
<script src="../../../dist/browser/bootlint.js"></script>
<script src="../generic-qunit.js"></script>
</head>
<body>
<div class="media">
<a class="pull-right" href="#">
<img src="data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9InllcyI/PjxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB3aWR0aD0iNjQiIGhlaWdodD0iNjQiIHZpZXdCb3g9IjAgMCA2NCA2NCIgcHJlc2VydmVBc3BlY3RSYXRpbz0ibm9uZSI+PGRlZnMvPjxyZWN0IHdpZHRoPSI2NCIgaGVpZ2h0PSI2NCIgZmlsbD0iI0VFRUVFRSIvPjxnPjx0ZXh0IHg9IjE0LjUiIHk9IjMyIiBzdHlsZT0iZmlsbDojQUFBQUFBO2ZvbnQtd2VpZ2h0OmJvbGQ7Zm9udC1mYW1pbHk6QXJpYWwsIEhlbHZldGljYSwgT3BlbiBTYW5zLCBzYW5zLXNlcmlmLCBtb25vc3BhY2U7Zm9udC1zaXplOjEwcHQ7ZG9taW5hbnQtYmFzZWxpbmU6Y2VudHJhbCI+NjR4NjQ8L3RleHQ+PC9nPjwvc3ZnPg==" />
</a>
<div class="media-body">
<h4 class="media-heading">Media heading</h4>
</div>
</div>
<div id="qunit"></div>
<ol id="bootlint">
<li data-lint="Using `pull-left` or `pull-right` as part of media component is deprecated. Please use `media-left` or `media-right`."></li>
</ol>
</body>
</html>