This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Warns about pull-* classes in media #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis fail looks to be because of the Bootstrap docs using pull-left & pull-right. |
| @@ -721,6 +721,12 @@ var semver = require('semver'); | |||
| reporter('Neither .form-inline nor .form-horizontal should be used directly on a `.form-group`. Instead, nest the .form-group within the .form-inline or .form-horizontal', badFormGroups); | |||
| } | |||
| }); | |||
| addLinter("W010", function lintMediaPulls($, reporter) { | |||
| var mediaPulls = $('.media').children('.pull-left, .pull-right'); | |||
There was a problem hiding this comment.
Use $('.media>.pull-left, .media>.pull-right')
iamphill
added a commit
to iamphill/bootlint
that referenced
this pull request
Oct 31, 2014
iamphill
added a commit
to iamphill/bootlint
that referenced
this pull request
Oct 31, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With v3.3,
pull-left&pull-rightwere deprecated insidemediaThis warns rather than error. I guess error it when support is dropped?
New warning number W010