Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with multiple contigs and sequence lengths #964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Sep 4, 2024

Introduces a contig_id parameter to variant_data, which adds non matching contigs to the site mask, as described in #949. Fixes #949

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.21%. Comparing base (7f23758) to head (8742ee8).

Files with missing lines Patch % Lines
tsinfer/formats.py 92.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   93.15%   93.21%   +0.05%     
==========================================
  Files          18       18              
  Lines        6368     6393      +25     
  Branches     1142     1151       +9     
==========================================
+ Hits         5932     5959      +27     
+ Misses        296      293       -3     
- Partials      140      141       +1     
Flag Coverage Δ
C 93.21% <92.30%> (+0.05%) ⬆️
python 95.56% <92.30%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyanwong
Copy link
Member Author

hyanwong commented Sep 7, 2024

Also fixes #763 I think

@hyanwong hyanwong force-pushed the multi-contig branch 3 times, most recently from f135465 to aa733d5 Compare September 10, 2024 12:30
Introduces a `contig_id` parameter to variant_data, as described in tskit-dev#949. Fixes tskit-dev#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VariantData sequence_length not being taken from zarr contig_length field
1 participant