Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override VariantData.from_tree_sequence #961

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Sep 4, 2024

Fixes #915

Copy link
Contributor

mergify bot commented Sep 4, 2024

⚠️ The sha of the head commit of this PR conflicts with #960. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (788d4df) to head (f8c62dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          18       18           
  Lines        6343     6346    +3     
  Branches     1134     1134           
=======================================
+ Hits         5910     5913    +3     
  Misses        294      294           
  Partials      139      139           
Flag Coverage Δ
C 93.17% <100.00%> (+<0.01%) ⬆️
python 95.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Sep 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #960. Mergify cannot evaluate rules on this PR. ⚠️

@mergify mergify bot merged commit 89b4ca0 into tskit-dev:main Sep 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SgkitSampleData.from_tree_sequence bugs out
3 participants