Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing goto and fix tests #164

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

jeromekelleher
Copy link
Member

Closes #160

This was a bug, but a vanishingly unlikely one to ever actually occur because it would have to happen when closing a read-only file.

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #164 (ec69b05) into main (19185bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          14       14           
  Lines        1294     1294           
  Branches      192      192           
=======================================
  Hits         1212     1212           
  Misses         50       50           
  Partials       32       32           
Flag Coverage Δ
C 93.66% <ø> (ø)
python 93.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19185bd...ec69b05. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d493fbe into tskit-dev:main Nov 22, 2021
@jeromekelleher jeromekelleher deleted the error-code-fix branch November 22, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error code not returned
2 participants