Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more sounds #305

Merged
merged 21 commits into from
Sep 1, 2020
Merged

Adds more sounds #305

merged 21 commits into from
Sep 1, 2020

Conversation

ashutoshgngwr
Copy link
Member

@ashutoshgngwr ashutoshgngwr commented Aug 31, 2020

Changes

See commit messages!

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

@ashutoshgngwr ashutoshgngwr added this to the 0.10.x milestone Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #305 into master will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   84.69%   85.04%   +0.35%     
==========================================
  Files          26       26              
  Lines        1313     1364      +51     
  Branches      149      151       +2     
==========================================
+ Hits         1112     1160      +48     
  Misses        106      106              
- Partials       95       98       +3     
Flag Coverage Δ
#android 85.04% <100.00%> (+0.35%) ⬆️
#ui_tests ?
#unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 98.85% <100.00%> (-0.56%) ⬇️
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 99.58% <100.00%> (+0.50%) ⬆️
...m/github/ashutoshgngwr/noice/MediaPlayerService.kt 86.11% <0.00%> (-1.86%) ⬇️
.../ashutoshgngwr/noice/sound/player/PlayerManager.kt 81.59% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2408c...8ec388c. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit c08aa87 into master Sep 1, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/more-sounds branch September 1, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion for new sound Suggestions for new sounds Cricket Sound
2 participants