Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add water hose sounds #157

Merged
merged 6 commits into from
Aug 21, 2020
Merged

Conversation

hitshydev
Copy link
Contributor

Changes

I've added two new sounds that I find quite calming when combined.
I had some trouble finding names that suit the sounds well, some feedback would be nice.

Testing

  • Tested on a physical device
  • Added or modified unit test cases

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (feat/more-sounds@8de5f5e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             feat/more-sounds     #157   +/-   ##
===================================================
  Coverage                    ?   84.60%           
===================================================
  Files                       ?       26           
  Lines                       ?     1325           
  Branches                    ?      149           
===================================================
  Hits                        ?     1121           
  Misses                      ?      106           
  Partials                    ?       98           
Flag Coverage Δ
#android 84.60% <0.00%> (?)
#ui_tests 64.24% <0.00%> (?)
#unit_tests 40.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de5f5e...0350b49. Read the comment docs.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitshydev I didn't get the time to properly test out the new sounds. But from the very first listen the water hose sound did seem to have some abrupt transitions. Also I am not sure if I am correctly recognising the water hosing sound. I'll test it out more. I think I'll need to resample the water hose sound. I am not sure about including the hosing sound though.

@ashutoshgngwr
Copy link
Member

Sorry for the delay on merging this. I have decided to defer all sound related change to 0.9.x. Considering #62 which would require rework on this if I merge it now.

@ashutoshgngwr ashutoshgngwr modified the milestones: 0.8.x, 0.9.x Jun 15, 2020
@ashutoshgngwr ashutoshgngwr removed this from the 0.9.x milestone Jul 20, 2020
@ashutoshgngwr ashutoshgngwr added this to the 0.10.x milestone Jul 20, 2020
@ashutoshgngwr ashutoshgngwr changed the base branch from master to feat/more-sounds August 21, 2020 18:26
@ashutoshgngwr ashutoshgngwr merged commit 9a864c4 into trynoice:feat/more-sounds Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants