-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add water hose sounds #157
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/more-sounds #157 +/- ##
===================================================
Coverage ? 84.60%
===================================================
Files ? 26
Lines ? 1325
Branches ? 149
===================================================
Hits ? 1121
Misses ? 106
Partials ? 98
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitshydev I didn't get the time to properly test out the new sounds. But from the very first listen the water hose sound did seem to have some abrupt transitions. Also I am not sure if I am correctly recognising the water hosing sound. I'll test it out more. I think I'll need to resample the water hose sound. I am not sure about including the hosing sound though.
b1e5cfc
to
79f25f9
Compare
ec3c946
to
711278d
Compare
Sorry for the delay on merging this. I have decided to defer all sound related change to 0.9.x. Considering #62 which would require rework on this if I merge it now. |
cf003aa
to
a1d333c
Compare
Changes
I've added two new sounds that I find quite calming when combined.
I had some trouble finding names that suit the sounds well, some feedback would be nice.
Testing