Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add water hose sounds #157

Merged
merged 6 commits into from
Aug 21, 2020
Merged

Add water hose sounds #157

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02436d9
Add water_hitting & water_hose sounds
hitshydev May 8, 2020
2a3c756
Add new sounds to credits
hitshydev May 8, 2020
0449bcd
Rename to hosing
hitshydev May 8, 2020
02ee5ea
chore(git): merge branch 'ashutoshgngwr/master' into PR #157
ashutoshgngwr May 10, 2020
ba1a1fe
chore(git): merge branch 'ashutoshgngwr/feat/more-sounds' into PR #157
ashutoshgngwr Aug 21, 2020
0350b49
refactor(app): split water hose into 2 samples, remove hosing sound
ashutoshgngwr Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added app/src/main/assets/water_hose.mp3
View file
Open in desktop
Binary file not shown.
Binary file added app/src/main/assets/water_hosing.mp3
View file
Open in desktop
Binary file not shown.
10 changes: 10 additions & 0 deletions app/src/main/java/com/github/ashutoshgngwr/noice/fragment/AboutFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,16 @@ class AboutFragment : Fragment() {
R.drawable.ic_stat_sound,
R.string.credits__sound_train_horn_url
),
arrayOf(
R.string.credits__sound_water_hose,
R.drawable.ic_stat_sound,
R.string.credits__sound_water_hose_url
),
arrayOf(
R.string.credits__sound_water_hosing,
R.drawable.ic_stat_sound,
R.string.credits__sound_water_hosing_url
),
arrayOf(
R.string.credits__sound_water_stream,
R.drawable.ic_stat_sound,
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/com/github/ashutoshgngwr/noice/sound/Sound.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ class Sound private constructor(
"soft_wind" to Sound("soft_wind", R.string.soft_wind),
"thunder_crack" to Sound("thunder_crack", R.string.thunder_crack, false),
"train_horn" to Sound("train_horn", R.string.train_horn, false),
"water_hose" to Sound("water_hose", R.string.water_hose),
"water_hosing" to Sound("water_hosing", R.string.water_hosing, isLoopable = false),
"water_stream" to Sound("water_stream", R.string.water_stream),
"white_noise" to Sound("white_noise", R.string.white_noise),
"wind_chimes_of_shells" to Sound("wind_chimes_of_shells", R.string.wind_in_chimes_of_shells),
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values-de/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
<string name="soft_wind">Leichter Wind</string>
<string name="thunder_crack">Donnerschlag</string>
<string name="train_horn">Zugsignal</string>
<string name="water_hose">Wasserschlauch</string>
<string name="water_hosing">Bewässern</string>
<string name="water_stream">Wasserlauf</string>
<string name="white_noise">Weißes Rauschen</string>
<string name="wind_in_palm_trees">Wind in Palmen</string>
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values/dont_translate.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@
</string>
<string name="credits__sound_train_horn" translatable="false">Train horn by CouleurCasquette</string>
<string name="credits__sound_train_horn_url" translatable="false">https://freesound.org/s/248229/</string>
<string name="credits__sound_water_hosing" translatable="false">Water hose spraying aginst wood (1) by Glitchmachines</string>
<string name="credits__sound_water_hosing_url" translatable="false">https://www.soundsnap.com/hosewood1_wav</string>
<string name="credits__sound_water_hose" translatable="false">Spraying water from a hose in a wide fan by SFX Bible</string>
<string name="credits__sound_water_hose_url" translatable="false">https://www.soundsnap.com/node/53530</string>
<string name="credits__sound_water_stream" translatable="false">Stream, Running Water | Aviemore Scotland by BurghRecords</string>
<string name="credits__sound_water_stream_url" translatable="false">https://freesound.org/s/415151/</string>
<string name="credits__sound_wind_chimes_of_shells" translatable="false">Wind chimes of shells from YouTube Audio Library</string>
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
<string name="soft_wind">Soft wind</string>
<string name="thunder_crack">Thunder crack</string>
<string name="train_horn">Train horn</string>
<string name="water_hose">Water hose</string>
<string name="water_hosing">Hosing</string>
<string name="water_stream">Water stream</string>
<string name="white_noise">White noise</string>
<string name="wind_in_palm_trees">Wind in Palm trees</string>
Expand Down