feat: did:web resolver should allow resolving DIDs that have different domain in DID if configured #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 87.94% 87.93% -0.01%
==========================================
Files 210 210
Lines 19797 19827 +30
==========================================
+ Hits 17410 17435 +25
- Misses 1525 1528 +3
- Partials 862 864 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
approved these changes
Sep 15, 2022
bstasyszyn
approved these changes
Sep 16, 2022
| @@ -64,8 +72,19 @@ func (r *ResolveHandler) ResolveDocument(id string) (*document.ResolutionResult, | |||
| r.metrics.WebDocumentResolveTime(time.Since(startTime)) | |||
| }() | |||
|
|
|||
| hostWithPort, err := util.BetweenStrings(id, "did:web:", ":scid:") | |||
There was a problem hiding this comment.
Not sure if the Parse DID function would be better to use here: https://github.com/hyperledger/aries-framework-go/blob/f7a0dc3a00bd4c8139e8c89e25d027e9093928a9/pkg/doc/did/doc.go#L92
There was a problem hiding this comment.
It would be better validation - I will change it.
sandrask
force-pushed
the
issue-1475
branch
from
f49b472
to
9e61d29
Compare
…t domain in DID if configured Limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains) Closes trustbloc#1475 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
sandrask
force-pushed
the
issue-1475
branch
from
9e61d29
to
6bdb527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit resolving did:web DIDs to current host domain plus configured additional domains.
Closes #1475
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com