Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

did:web resolver should allow resolving DIDs that have different domain in DID if configured #1475

Closed
sandrask opened this issue Sep 7, 2022 · 2 comments · Fixed by #1484
Closed

did:web resolver should allow resolving DIDs that have different domain in DID if configured #1475

sandrask opened this issue Sep 7, 2022 · 2 comments · Fixed by #1484
Assignees
@sandrask
Labels
enhancement New feature or request
Milestone
0.1.8

Comments

@sandrask
Copy link
Contributor

sandrask commented Sep 7, 2022 •
edited
Loading

For example if the request to resolve did:web:orb.domain3.com:scid:suffix was sent to https://orb.domain1.com/sidetree/v1/identifiers should we resolve the DID if we have it (due to propagation we may have DID with that suffix)

As per discussing with @troyronda we should limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)
@sandrask
Copy link
Contributor Author

sandrask commented Sep 7, 2022

@troyronda Any opinion on this?

@sandrask sandrask self-assigned this Sep 7, 2022
@sandrask sandrask added the enhancement New feature or request label Sep 7, 2022
@sandrask sandrask added this to the 0.1.8 milestone Sep 14, 2022
@sandrask sandrask changed the title Should did:web resolver allow resolving DID that has different domain in did web ID did:web resolver should limit resolving DIDs that has different domain in did web ID if configured Sep 15, 2022
@sandrask
Copy link
Contributor Author

sandrask commented Sep 15, 2022 •
edited
Loading

As per discussing with @troyronda we should limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)

@sandrask sandrask changed the title did:web resolver should limit resolving DIDs that has different domain in did web ID if configured did:web resolver should allow resolving DIDs that have different domain in DID if configured Sep 15, 2022
sandrask added a commit to sandrask/orb that referenced this issue Sep 15, 2022
@sandrask
feat: did:web resolver should allow resolving DIDs that have differen…
6dcecdd 
…t domain in DID if configured

Limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)

Closes trustbloc#1475

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
sandrask added a commit to sandrask/orb that referenced this issue Sep 15, 2022
@sandrask
feat: did:web resolver should allow resolving DIDs that have differen…
c880f80 
…t domain in DID if configured

Limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)

Closes trustbloc#1475

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
sandrask added a commit to sandrask/orb that referenced this issue Sep 15, 2022
@sandrask
feat: did:web resolver should allow resolving DIDs that have differen…
a6e5ae2 
…t domain in DID if configured

Limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)

Closes trustbloc#1475

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
sandrask added a commit to sandrask/orb that referenced this issue Sep 15, 2022
@sandrask
feat: did:web resolver should allow resolving DIDs that have differen…
f49b472 
…t domain in DID if configured

Limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)

Closes trustbloc#1475

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask mentioned this issue Sep 15, 2022
Merged
sandrask added a commit to sandrask/orb that referenced this issue Sep 16, 2022
@sandrask
feat: did:web resolver should allow resolving DIDs that have differen…
9e61d29 
…t domain in DID if configured

Limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)

Closes trustbloc#1475

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
sandrask added a commit to sandrask/orb that referenced this issue Sep 16, 2022
@sandrask
feat: did:web resolver should allow resolving DIDs that have differen…
6bdb527 
…t domain in DID if configured

Limit resolving did:web DIDs to those with hosting domain in DID (or configured additional domains)

Closes trustbloc#1475

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandrask sandrask

Labels
enhancement New feature or request
Projects
No open projects
TrustBloc Orb
Status: Done
Milestone
0.1.8
1 participant
@sandrask