feat(test): improve unit test coverage #5988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxcmyf
force-pushed
the
feature/improve_coverage
branch
3 times, most recently
from
d40da4a
to
b910d33
Compare
lxcmyf
force-pushed
the
feature/improve_coverage
branch
2 times, most recently
from
33736f8
to
27235e8
Compare
yuekun0707
approved these changes
Sep 19, 2024
framework/src/test/java/org/tron/common/cache/TronCacheTest.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/org/tron/common/logsfilter/capsule/BlockLogTriggerCapsuleTest.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/org/tron/common/logsfilter/capsule/ContractLogTriggerCapsuleTest.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/org/tron/common/logsfilter/capsule/ContractTriggerCapsuleTest.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/org/tron/common/runtime/vm/BatchSendTest.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/org/tron/common/runtime/vm/DataWordTest.java
Outdated
Show resolved
Hide resolved
|
BTW, given that this PR adds a lot of tests, how much impact will the newly added tests have on the CI test time? |
|
@tomatoishealthy |
lxcmyf
force-pushed
the
feature/improve_coverage
branch
from
27235e8
to
f9a86f7
Compare
tomatoishealthy
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
improve unit test coverage, close #5434
Why are these changes required?
This PR has been tested by:
Follow up
Extra details