Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage to 70% #5434

Open
3 of 5 tasks
forfreeday opened this issue Aug 17, 2023 · 13 comments · May be fixed by #5988
Open
3 of 5 tasks

Improve code coverage to 70% #5434

forfreeday opened this issue Aug 17, 2023 · 13 comments · May be fixed by #5988

Comments

@forfreeday
Copy link
Contributor

forfreeday commented Aug 17, 2023

Rationale

Why should this feature exist?

To improve the test case coverage of your code, cover as much as possible.

Implementation

database

api

net

Are you willing to implement this feature?
Yes, I would like to complete these use cases and would like to have more people participate in them.

@halibobo1205 halibobo1205 changed the title Add more test cases Improve code coverage Aug 17, 2023
@halibobo1205 halibobo1205 changed the title Improve code coverage Improve code coverage to 70% Aug 17, 2023
@xxo1shine
Copy link
Contributor

@forfreeday This is a good idea, it is really necessary to increase the unit test rate to avoid introducing bugs.

@forfreeday
Copy link
Contributor Author

@wubin01

Yes, this will be ongoing, with 70% coverage in the first phase

@forfreeday
Copy link
Contributor Author

Current coverage: 66.48%.
Continuously adding test cases, expected to reach 70% coverage in June.

@forfreeday
Copy link
Contributor Author

Current coverage status:

  • actuator: 75.33%
  • chainbase: 77.40%
  • common: 60.69%
  • consensus: 63.49%
  • crypto: 71.62%
  • framework: 57.51%
  • plugins: 70.18%

@forfreeday
Copy link
Contributor Author

forfreeday commented Apr 12, 2024

Current coverage status:

  • actuator: 75.33%
  • chainbase: 77.40%
  • common: 60.69%
  • consensus: 63.49%
  • crypto: 71.62%
  • framework: 60.51%
  • plugins: 70.18%

@lxcmyf
Copy link
Contributor

lxcmyf commented Jul 4, 2024

Current coverage status:

  • actuator: 75.49%
  • chainbase: 77.56%
  • common: 61.29%
  • consensus: 63.75%
  • crypto: 71.62%
  • framework: 57.74%
  • plugins: 71.84%

Subsequently, we will focus on enhancing and increasing the unit test coverage of the framework、common and consensus module.

@Goodmanisrael27
Copy link

Uploading VID-20240705-WA0000.mp4…

@Alximm
Copy link

Alximm commented Jul 15, 2024

Rationale

Why should this feature exist?

To improve the test case coverage of your code, cover as much as possible.

Implementation

database

api

net

Are you willing to implement this feature?
Yes, I would like to complete these use cases and would like to have more people participate in them.

@lxcmyf
Copy link
Contributor

lxcmyf commented Jul 26, 2024

Some development work aimed at improving code coverage for low-coverage modules is already in the planning stage.

@lxcmyf
Copy link
Contributor

lxcmyf commented Aug 28, 2024

At present, the total coverage rate has reached 66.85%. The following are the latest coverage statistics for each module. Some modules have slightly fluctuated compared to before, which is a normal phenomenon. We now plan to focus on improving the modules with low coverage rates. Currently, the improvement work for the framework module is being carried out urgently, and the improvement of other modules is also being carried out in an orderly manner.
image

@lxcmyf
Copy link
Contributor

lxcmyf commented Sep 4, 2024

Current coverage status:

image

The total coverage rate is 67.82%.

@lxcmyf lxcmyf linked a pull request Sep 11, 2024 that will close this issue
@lxcmyf
Copy link
Contributor

lxcmyf commented Sep 12, 2024

Current coverage status:
image
The total coverage rate is 69.19%.

@lxcmyf
Copy link
Contributor

lxcmyf commented Sep 19, 2024

Another PR aimed at improving coverage is currently being prepared and will be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
@forfreeday @lxcmyf @xxo1shine @halibobo1205 @Alximm @Goodmanisrael27 and others