Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our documentation until we release Reek 5. #1329

Merged
merged 1 commit into from
Jun 10, 2018

Conversation

troessner
Copy link
Owner

Fixes #1327

@mvz
Copy link
Collaborator

mvz commented Jun 10, 2018

Oh man I'm torn about this.

I was going to say if we're going for the solution where we have to change the README just before the release we can just put a pointer to the v4.8.1 README, so documentation an code actually match for the given repo state.

However, this PR also solves the problem that all our -U links link to the master branch. The really terrible thing is that even after we release 5.0 there will be people using 4.x and getting broken links.

@troessner
Copy link
Owner Author

However, this PR also solves the problem that all our -U links link to the master branch. The really terrible thing is that even after we release 5.0 there will be people using 4.x and getting broken links.

Oh yeah, boy, we really did NOT think this whole thing through, now did we 😆

I'm all up for fixing #1330 asap but what do you think about merging this PR first and independently of that so that at least the majority of our docs are sane again?

@mvz
Copy link
Collaborator

mvz commented Jun 10, 2018

Ok, how about:

  • Putting just a notice in the README saying 'This is the README for master, please look here for the currently released version'
  • Putting back the PrimaDonnaMethod documentation, ideally with a notice that it will be renamed in 5.0.
  • Leaving the rest as-is so we don't get confused.

I agree that #1330 is something we can fix after we stopped the current confusion.

@troessner troessner force-pushed the fix-our-documentation-until-we-release-reek-5 branch from 10ba2e2 to 0d65c1f Compare June 10, 2018 12:37
@troessner
Copy link
Owner Author

troessner commented Jun 10, 2018

Putting back the PrimaDonnaMethod documentation, ideally with a notice that it will be renamed in 5.0.

Just did that.

Putting just a notice in the README saying 'This is the README for master, please look here for the currently released version'

Unless we make that "marquee" and "h1" i doubt people are reading that, especially if you quickly want to look something up (what most of our users are doing i suppose) you won't catch that.

@@ -33,7 +33,7 @@ An more sophisticated rake task that would make use of all available configurati
```Ruby
Reek::Rake::Task.new do |t|
t.name = 'custom_rake' # Whatever name you want. Defaults to "reek".
t.config_file = 'config/.reek.yml' # Defaults to nothing.
t.config_file = 'config/config.reek' # Defaults to nothing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can stay as it is I think.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's true that we're not checking for the file extension explicitly when specifying a config file I still think it's very confusing that all of a sudden we have a configuration file with a yaml extension.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait I missed that this was also in the docs. Please ignore my remark for this line.

@mvz
Copy link
Collaborator

mvz commented Jun 10, 2018

Unless we make that "marquee" and "h1" i doubt people are reading that, especially if you quickly want to look something up (what most of our users are doing i suppose) you won't catch that.

I like to think I always notice, but there's no way of knowing, is there? Anyway, let's just merge this so we can think of the Awesomest Best Solution for Pointing People to the Right Documentation (ABSPPRD) at leisure.

@troessner
Copy link
Owner Author

And merged it is ;)

@troessner troessner merged commit d8e4925 into master Jun 10, 2018
@troessner troessner deleted the fix-our-documentation-until-we-release-reek-5 branch June 10, 2018 13:35
@troessner troessner mentioned this pull request Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants