-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix our documentation until we release Reek 5. #1329
Fix our documentation until we release Reek 5. #1329
Conversation
Oh man I'm torn about this. I was going to say if we're going for the solution where we have to change the README just before the release we can just put a pointer to the v4.8.1 README, so documentation an code actually match for the given repo state. However, this PR also solves the problem that all our |
Oh yeah, boy, we really did NOT think this whole thing through, now did we 😆 I'm all up for fixing #1330 asap but what do you think about merging this PR first and independently of that so that at least the majority of our docs are sane again? |
Ok, how about:
I agree that #1330 is something we can fix after we stopped the current confusion. |
10ba2e2
to
0d65c1f
Compare
Just did that.
Unless we make that "marquee" and "h1" i doubt people are reading that, especially if you quickly want to look something up (what most of our users are doing i suppose) you won't catch that. |
@@ -33,7 +33,7 @@ An more sophisticated rake task that would make use of all available configurati | |||
```Ruby | |||
Reek::Rake::Task.new do |t| | |||
t.name = 'custom_rake' # Whatever name you want. Defaults to "reek". | |||
t.config_file = 'config/.reek.yml' # Defaults to nothing. | |||
t.config_file = 'config/config.reek' # Defaults to nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can stay as it is I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's true that we're not checking for the file extension explicitly when specifying a config file I still think it's very confusing that all of a sudden we have a configuration file with a yaml extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait I missed that this was also in the docs. Please ignore my remark for this line.
I like to think I always notice, but there's no way of knowing, is there? Anyway, let's just merge this so we can think of the Awesomest Best Solution for Pointing People to the Right Documentation (ABSPPRD) at leisure. |
And merged it is ;) |
Fixes #1327