Let's release Reek 5

[troessner]

Here's my suggestion list:

• Change PrimaDonnaMethod to MissingSafeMethod
• Introduce a --list option - no particular reason, I just really like the idea
• Whatever we can sneak in from the other items on our "breaking change" list

Afterwards we should release a new version on CodeClimate to fix the problems with the Syntax smell

Thoughts? :)

[mvz]

Ideally, I'd like to include all of the breaking changes. Any that we don't include should be closed.

[mvz]

I'm going to pick up some of those breaking changes over the weekend.

[troessner]

Ideally, I'd like to include all of the breaking changes. Any that we don't include should be closed.

Good point.

I'm going to pick up some of those breaking changes over the weekend.

Me too probably. Let's make sure we always assign the issue to ourselves and write a comment that we're working on it to not duplicate work :)

[troessner]

Almost there <3 ;)

[troessner]

Status:

Recently done:

* Finish:
  * #1322 
  * If its not too much effort, sneak in #1319 

Left to do:

Release v5

• Finish Prepare Reek 5 release. #1324:
  • don't forget to add the new entries to the changelog
  • Write a helpful migration doc in /docs so users can easily transition from Reek 4 to Reek 5 and link it prominently at the beginning of the README
• Add the documentation that we removed in Fix our documentation until we release Reek 5. #1329 by reverting that PR
• Merge both PRs and then release the new version

Post release

• Release a new CodeClimate version
  • Ensure that Ruby 2.5 compatibility problem in CodeClimate engine #1325 works
  • And docs/Syntax.md is missing #1291

[troessner]

Now that #1322 is out i'd like to give #1319 a quick shot just to make sure that in the scope of the pull request we do not need any other breaking change. That is something I'll look into today.

[troessner]

Ok, it looks like #1317 won't add anything breaking so we don't have to wait for this to finish to release Reek 5 ;)
Let's continue with #1324

[troessner]

Ready to roll, let's go!

[mvz]

#1343 may introduce a breaking change to Examiner so we should probably wait for that.

[troessner]

Right, good point!

[mvz]

We also need to actually add Syntax.md or remove the detector to really fix #1291.

[troessner]

Let's finish and merge all PR's labeled with breaking changes and then release v5 ;)

[mvz]

All breaking changes were merged 🎉!

[troessner]

Wait, one more! 😆
Source: click

What a coincidence 🌈