Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jakarta servlet and JAX-RS dependencies #17770

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2023
@wendigo wendigo requested a review from electrum June 6, 2023 13:23
@github-actions github-actions bot added bigquery BigQuery connector hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver tests:hive labels Jun 6, 2023
@electrum electrum changed the title Airlift 233 and Tempto 197 Update to Jakarta dependencies Jun 6, 2023
@electrum electrum changed the title Update to Jakarta dependencies Update to Jakarta servlet and JAX-RS dependencies Jun 6, 2023
@github-actions github-actions bot added the delta-lake Delta Lake connector label Jun 7, 2023
@wendigo wendigo requested a review from electrum June 7, 2023 04:15
@wendigo
Copy link
Contributor Author

wendigo commented Jun 7, 2023

I've applied error-prone fixes (coming from #17740) @electrum

@wendigo wendigo mentioned this pull request Jun 7, 2023
@wendigo wendigo force-pushed the airlift233 branch 2 times, most recently from c294a9e to d6e59e0 Compare June 7, 2023 04:18
@wendigo
Copy link
Contributor Author

wendigo commented Jun 7, 2023

@hashhar can you run this PR with secrets?

@kokosing
Copy link
Member

kokosing commented Jun 7, 2023

/test-with-secrets sha=d2a3bbb62bc7e19a35693109912bd7e979877d6e

electrum and others added 4 commits June 7, 2023 14:09
Additionally fix/suppress error-prone `CheckReturnValue` violations with Guava 32.0.0
that was upgraded in Airbase 141.

These are the result of following changes:

- google/guava@a7f6b08
- google/guava@0ef6688

Co-authored-by: Mateusz "Serafin" Gajewski <mateusz.gajewski@gmail.com>
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5199383182

@kokosing
Copy link
Member

kokosing commented Jun 7, 2023

/test-with-secrets sha=501f1e0926aad64a88534ca5e1f060060b4fe93f

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5200355698

@wendigo
Copy link
Contributor Author

wendigo commented Jun 7, 2023

Failures are preexisting

@electrum electrum merged commit 9336c2b into trinodb:master Jun 7, 2023
@wendigo wendigo deleted the airlift233 branch June 7, 2023 18:03
@github-actions github-actions bot added this to the 420 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery BigQuery connector cla-signed delta-lake Delta Lake connector hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver
Development

Successfully merging this pull request may close these issues.

5 participants