Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tempto to use com.google.inject #115

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 6, 2023

This change:

  • updates airbase to 140 with Guice 6.0.0
  • switches injection annotation to be Guice-based
  • adds minimal support for jakarta.inject annotations

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2023
@wendigo
Copy link
Contributor Author

wendigo commented Jun 6, 2023

cc @electrum

tempto-core/pom.xml Show resolved Hide resolved
tempto-core/pom.xml Show resolved Hide resolved
@wendigo wendigo force-pushed the serafin/tempto-google-inject branch from b602c97 to 3255849 Compare June 6, 2023 18:57
This change:

- updates airbase to 141 with Guice 7.0.0
- switches injection annotation to be Guice-based
- adds support for jakarta.inject annotations
@wendigo wendigo force-pushed the serafin/tempto-google-inject branch from 3255849 to f3558cb Compare June 6, 2023 19:49
@wendigo wendigo requested a review from electrum June 6, 2023 19:50
@electrum electrum merged commit 55963fa into trinodb:master Jun 6, 2023
@wendigo wendigo deleted the serafin/tempto-google-inject branch June 12, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants