-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry product tests on MapRedTask ClosedByInterruptException failures #15879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With stacktrace in the middle, it's hard to find the end of the message, so it's hard to read it as a sentence.
findepi
added
no-release-notes
This pull request does not require release notes entry
dx
Issues or pull requests related to developer experience
labels
Jan 27, 2023
findepi
requested review from
nineinchnick,
raunaqmorarka,
sopel39,
ebyhr,
kokosing and
hashhar
January 27, 2023 13:55
findepi
commented
Jan 27, 2023
/** | ||
* Link to issues: | ||
* <ul> | ||
* <ol><a href="https://github.com/trinodb/trino/issues/4936">#4936</a></ol> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
findepi
commented
Jan 27, 2023
* Link to issues: | ||
* <ul> | ||
* <ol><a href="https://github.com/trinodb/trino/issues/4936">#4936</a></ol> | ||
* <ol><a href="https://github.com/trinodb/trino/issues/5427">#5427</a></ol> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing through Hive can fail in ways other than just "could only be replicated to 0 nodes instead of minReplication". Let's make the names of constants more generic to support more cases in the future, and also abstract what the underlying problem may be.
findepi
force-pushed
the
findepi/channel-closed
branch
from
January 27, 2023 13:59
d4f25b4
to
c9ec513
Compare
Merged
ebyhr
approved these changes
Jan 30, 2023
CI #12535 |
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
dx
Issues or pull requests related to developer experience
no-release-notes
This pull request does not require release notes entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retries for #5427 (close #5427)