-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky Hive product tests: Error committing write to Hive #4936
Comments
|
@MiguelWeezardo would it be possible to add a retry to |
That should not be enabled by default. There are plenty of queries that should not be retried or they are simply not retryable. How about.
? Another option is wrapping query executors like:
|
@kokosing i meant to only retry those that fail with trino/testing/trino-product-tests/src/main/java/io/trino/tests/hive/HiveProductTest.java Lines 26 to 28 in cea5842
plus, we can match on the query being done, eg it's not safe to retry INSERT statements
if i were to change each test's code, i'd just continue with the current approach
|
Should be fixed by #6601 |
Hopefully solved by #6601 thanks @MiguelWeezardo if that turns out not to be sufficient in some cases, we may need a more focused approach in those cases, so let me close the issue |
Well, I saw what looks like this in one of my PRs: https://github.com/trinodb/trino/runs/1911881714?check_suite_focus=true#step:6:12515 |
The Failsafe code is on the failure stack, but it looks like no retries were attempted. |
Is there any issues with message regex? |
The regex is multiline, and focuses on messages from two different exceptions in the causal chain, which may be why it didn't match. |
|
That's why it has |
I thought it's a simple non-capturing group, and failed to notice the |
I copied the matching from |
Happens also to Iceberg+Spark tests when trying to write to HDFS: |
We have retries in place, so no more work planned to be done here, I am closing the issue Please reopen if you see this again. Be sure to provide failure link AND stacktraces. Github actions logs are not kept for ever. |
https://github.com/prestosql/presto/pull/4846/checks?check_run_id=1017285394
The text was updated successfully, but these errors were encountered: