Remove deprecated checkCanCreateSchema #15618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retaining the deprecated method was not sufficient for maintaining compatibility, because the new method did not delegate to the old one. Thus, if an implementor kept implementing only the old method, the CREATE SCHEMA would get denied, irrespective of the implemented logic. Removing the deprecated method makes the incompatibility clearer, as it fails at the compilation time.
findepi
added
the
no-release-notes
findepi
requested review from
electrum,
dain,
losipiuk,
kokosing and
Praveen2112
electrum
approved these changes
Jan 5, 2023
kokosing
approved these changes
Jan 5, 2023
|
Thank you |
dain
approved these changes
Jan 11, 2023
Praveen2112
approved these changes
Jan 11, 2023
How would it be better than delegating from the new one to the old one?
Agreed. |
findepi
deleted the
findepi/remove-deprecated-checkcancreateschema-270ea8
branch
utk-spartan
added a commit
to utk-spartan/ranger
that referenced
this pull request
Mar 8, 2023
Incorporate following changes Remove deprecated checkCanCreateSchema trinodb/trino#15618 trinodb/trino@0fac087 Disallow multiple masks on a given column trinodb/trino#15680 trinodb/trino@bdd1cb5
utk-spartan
added a commit
to razorpay/ranger
that referenced
this pull request
Mar 8, 2023
Incorporate following changes Remove deprecated checkCanCreateSchema trinodb/trino#15618 trinodb/trino@0fac087 Disallow multiple masks on a given column trinodb/trino#15680 trinodb/trino@bdd1cb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retaining the deprecated method was not sufficient for maintaining compatibility, because the new method did not delegate to the old one. Thus, if an implementor kept implementing only the old method, the CREATE SCHEMA would get denied, irrespective of the implemented logic. Removing the deprecated method makes the incompatibility clearer, as it fails at the compilation time.
Follows #15153 (comment)