Pass properties when checking access for CREATE SCHEMA #15153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
force-pushed
the
origin/master/161_schema_props
branch
2 times, most recently
from
e8c66b1 to
19ac128
Compare
Praveen2112
approved these changes
Nov 24, 2022
core/trino-main/src/main/java/io/trino/security/InjectedConnectorAccessControl.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/security/SystemAccessControl.java
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/security/SystemAccessControl.java
Outdated
Show resolved
Hide resolved
kokosing
force-pushed
the
origin/master/161_schema_props
branch
from
19ac128 to
b01b550
Compare
|
CI hit: #14814 |
|
Do we need release notes for this? |
|
No user visible impact. It changed the SPI though: |
findepi
reviewed
Jan 5, 2023
| */ | ||
| default void checkCanCreateSchema(SystemSecurityContext context, CatalogSchemaName schema, Map<String, Object> properties) | ||
| { | ||
| denyCreateSchema(schema.toString()); |
There was a problem hiding this comment.
Why not delegate to checkCanCreateSchema(context, schema)?
that would make the change backward-compatible.
There was a problem hiding this comment.
proposing #15618 to address this
There was a problem hiding this comment.
You are right. That was a mistake.
utk-spartan
added a commit
to utk-spartan/ranger
that referenced
this pull request
Mar 8, 2023
Incorporate following changes Pass properties when checking access for CREATE SCHEMA trinodb/trino#15153 trinodb/trino@e16620f Support ALTER COLUMN SET DATA TYPE statement trinodb/trino#11608 trinodb/trino@ef94c0d
utk-spartan
added a commit
to razorpay/ranger
that referenced
this pull request
Mar 8, 2023
Incorporate following changes Pass properties when checking access for CREATE SCHEMA trinodb/trino#15153 trinodb/trino@e16620f Support ALTER COLUMN SET DATA TYPE statement trinodb/trino#11608 trinodb/trino@ef94c0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass properties when checking access for CREATE SCHEMA