Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTrilinos: Update FinMpi4Py.cmake to support Python 3 #8444

Merged
merged 1 commit into from
Dec 10, 2020
Merged

PyTrilinos: Update FinMpi4Py.cmake to support Python 3 #8444

merged 1 commit into from
Dec 10, 2020

Conversation

kliegeois
Copy link
Contributor

@trilinos/pytrilinos

Motivation

This is a small PR to update the FindMpi4Py.cmake to support Python 3.

Stakeholder Feedback

Testing

@kliegeois kliegeois added pkg: PyTrilinos AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Dec 9, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_cuda_9.2 to start: Total Wait = 603

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_cuda_9.2 to start: Total Wait = 603

@kliegeois kliegeois mentioned this pull request Dec 10, 2020
Merged
bartlettroscoe
bartlettroscoe reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me but I don't know who can approve PyTrilinos changes at this point. There is no automated testing for PyTrilinos so PR testing will not catch any problems.

@kliegeois
Copy link
Contributor Author

Fine by me but I don't know who can approve PyTrilinos changes at this point. There is no automated testing for PyTrilinos so PR testing will not catch any problems.

@bartlettroscoe thanks for your review! I do not know who can approve those changes too.

@mhoemmen
Copy link
Contributor

@kliegeois Just checking if I was somehow still a PyTrilinos admin. I don't think I am any more. In any case, the changes look reasonable (I've been writing a lot of Python 3 lately), assuming that FindMpi4Py.cmake works with Python 3.

@mperego mperego added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Dec 10, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 2977
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 612
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 1105
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 8467
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 6184
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 1319
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 4079
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Using Repos:

Repo: TRILINOS (kliegeois/Trilinos)
  • Branch: pytrilinos
  • SHA: 0da108d
  • Mode: TEST_REPO

Pull Request Author: kliegeois

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 2977
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 612
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 1105
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 8467
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 6184
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 1319
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 4079
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST;pkg: PyTrilinos
PULLREQUESTNUM 8444
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH pytrilinos
TRILINOS_SOURCE_REPO https://github.com/kliegeois/Trilinos
TRILINOS_SOURCE_SHA 0da108d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9c7e554


CDash Test Results for PR# 8444.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Dec 10, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

mperego
mperego approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@mperego mperego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mperego mperego merged commit 4c5776a into trilinos:develop Dec 10, 2020
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Dec 11, 2020
Merge 'trilinos/Trilinos:develop' (1d57a92) into 'tcad-charon/Trilino…
6d91d8c 
…s:develop' (59cf6cc).

* trilinos-develop: (48 commits)
  PyTrilinos: Update FinMpi4Py.cmake to support Python 3 (trilinos#8444)
  Intrepid: fix bug in face tag initialization for high-order H(div) Triangle elements. (trilinos#8453)
  Minor fix to SuperLu version used for enum
  kokkos: Replace enums in Kokkos_ViewMapping.hpp
  Framework: Enabling the 'autocloser' github actions script
  Tun off build stats compiler wrappers in all PR builds for now (trilinos#7376)
  Set Trilinos_REMOVE_BUILD_STATS_TIMING_FILES_ON_FRESH_CONFIGURE=ON for cuda_9.2 PR build (trilinos#7376)
  Add support for <Project>_REMOVE_BUILD_STATS_TIMING_FILES_ON_FRESH_CONFIGURE (trilinos#7376)
  Simplify logic for setting <Project>_REMOVE_BUILD_STATS_ON_CONFIGURE (trilinos#7376)
  Remove commented out debug print statements (trilinos#7376)
  Make work with Python 3.6 (trilinos#7376)
  Update to work with Python 3.6 (trilinos#7376)
  TriBITS: Close filehanlde objects to avoid warning with Python 3.6 (trilinos#7376)
  TriBITS: Make csvsreader next() work with Python 3.x (trilinos#7376)
  Change to 'except <type> as <obj>' for Python 3.6 (trilinos#7376)
  Revert "Build stats wrapper python needs 2.7+, not 2.6 (trilinos#7376)"
  Add normalizeFileNameField() (trilinos#7376)
  Add default option computeStdScaledFields=True and rename to getBuildStatsForTests() (trilinos#7376)
  Update documentation for build stats (trilinos#7376)
  Add --bin-by-subdirs-under-dirs=commonTools,packages (trilinos#7376)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Dec 11, 2020
Merge 'trilinos/Trilinos:develop' (1d57a92) into 'tcad-charon/Trilino…
7f2dc83 
…s:develop' (59cf6cc).

* trilinos-develop: (48 commits)
  PyTrilinos: Update FinMpi4Py.cmake to support Python 3 (trilinos#8444)
  Intrepid: fix bug in face tag initialization for high-order H(div) Triangle elements. (trilinos#8453)
  Minor fix to SuperLu version used for enum
  kokkos: Replace enums in Kokkos_ViewMapping.hpp
  Framework: Enabling the 'autocloser' github actions script
  Tun off build stats compiler wrappers in all PR builds for now (trilinos#7376)
  Set Trilinos_REMOVE_BUILD_STATS_TIMING_FILES_ON_FRESH_CONFIGURE=ON for cuda_9.2 PR build (trilinos#7376)
  Add support for <Project>_REMOVE_BUILD_STATS_TIMING_FILES_ON_FRESH_CONFIGURE (trilinos#7376)
  Simplify logic for setting <Project>_REMOVE_BUILD_STATS_ON_CONFIGURE (trilinos#7376)
  Remove commented out debug print statements (trilinos#7376)
  Make work with Python 3.6 (trilinos#7376)
  Update to work with Python 3.6 (trilinos#7376)
  TriBITS: Close filehanlde objects to avoid warning with Python 3.6 (trilinos#7376)
  TriBITS: Make csvsreader next() work with Python 3.x (trilinos#7376)
  Change to 'except <type> as <obj>' for Python 3.6 (trilinos#7376)
  Revert "Build stats wrapper python needs 2.7+, not 2.6 (trilinos#7376)"
  Add normalizeFileNameField() (trilinos#7376)
  Add default option computeStdScaledFields=True and rename to getBuildStatsForTests() (trilinos#7376)
  Update documentation for build stats (trilinos#7376)
  Add --bin-by-subdirs-under-dirs=commonTools,packages (trilinos#7376)
  ...
bathmatt pushed a commit that referenced this pull request Dec 16, 2020
Merge 'trilinos/Trilinos:develop' (9c7e554) into 'EM-Plasma/Trilinos:…
c6ac7b3 
…develop' (e46fbab).

* potential-trilinos-develop: (64 commits)
  Framework: Reduce rate limit for stale job actionscript
  Updated ninja
  Panzer: fix race condition with launch blocking off in GED accessor.
  Updated to cmake 19 for Ross' cuda schedule fixes
  TrilinosCouplings: Fixing maxwell example
  TrilinosCouplings: Fixing bug
  TrilinosCouplings: Minor mods to Maxwell example
  Tpetra: Fix issue in `transferAndFillComplete`
  Tpetra: Add test for #8447
  PyTrilinos: Update FinMpi4Py.cmake to support Python 3 (#8444)
  Intrepid: fix bug in face tag initialization for high-order H(div) Triangle elements. (#8453)
  Minor fix to SuperLu version used for enum
  kokkos: Replace enums in Kokkos_ViewMapping.hpp
  Framework: Enabling the 'autocloser' github actions script
  Framework: Issue 8429 - TestingEnv Fixes
  Ifpack2: fix initialization error
  Tun off build stats compiler wrappers in all PR builds for now (#7376)
  Set Trilinos_REMOVE_BUILD_STATS_TIMING_FILES_ON_FRESH_CONFIGURE=ON for cuda_9.2 PR build (#7376)
  Add support for <Project>_REMOVE_BUILD_STATS_TIMING_FILES_ON_FRESH_CONFIGURE (#7376)
  Simplify logic for setting <Project>_REMOVE_BUILD_STATS_ON_CONFIGURE (#7376)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe left review comments

@mhoemmen mhoemmen mhoemmen approved these changes

@mperego mperego mperego approved these changes

Assignees
No one assigned
Labels
AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: PyTrilinos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kliegeois @trilinos-autotester @mhoemmen @bartlettroscoe @mperego