Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kokkos: Replace enums in Kokkos_ViewMapping.hpp #8446

Merged

Conversation

ndellingwood
Copy link
Contributor

Hotpatch of PR kokkos/kokkos#3422 by @masterleinad

@trilinos/kokkos

Motivation

Apply patch from kokkos/kokkos#3422 to silence -Wextra messages as required for Sierra project

CC: @mwglass

@ndellingwood ndellingwood requested a review from crtrott December 9, 2020 20:27
@ndellingwood ndellingwood added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Dec 9, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for Sierra integration, which wants to turn on Wextra Werror ...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_cuda_9.2 to start: Total Wait = 603

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_cuda_9.2 to start: Total Wait = 603

@ndellingwood
Copy link
Contributor Author

Issues logging into ride likely causing the cuda test timeout, will have to wait for that to resolve before retesting

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_cuda_9.2 to start: Total Wait = 603

@ndellingwood ndellingwood added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Dec 10, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 2970
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 605
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 1098
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 8462
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 6179
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 1314
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 4075
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Using Repos:

Repo: TRILINOS (ndellingwood/Trilinos)
  • Branch: hotpatch-kokkos-3422
  • SHA: e26c9df
  • Mode: TEST_REPO

Pull Request Author: ndellingwood

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 2970
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 605
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 1098
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 8462
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 6179
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 1314
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 4075
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;AT: RETEST
PULLREQUESTNUM 8446
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH hotpatch-kokkos-3422
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA e26c9df
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e29f0be


CDash Test Results for PR# 8446.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Dec 10, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ crtrott ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit bca14d1 into trilinos:develop Dec 10, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 8446: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Dec 10, 2020
@ndellingwood ndellingwood deleted the hotpatch-kokkos-3422 branch December 10, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants