ATDM/cts1empire: Create cts1empire and set as default env (ATDV-367) #7518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e10harvey
added
ATDM Env Issue
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Master Merge AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_7.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: e10harvey |
|
Status Flag 'Master Merge AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 15 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_7.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 7010 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 6820 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 5245 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 5092 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 1281 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_7.0.1 # 233 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_9.0.0 # 951 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 4576 (click to expand) |
bartlettroscoe
requested changes
Jun 11, 2020
...s/atdm/cts1empire/drivers/Trilinos-atdm-cts1-intel-19.0.5_openmpi-4.0.1_openmp_static_dbg.sh
Outdated
Show resolved
Hide resolved
...s/atdm/cts1empire/drivers/Trilinos-atdm-cts1-intel-19.0.5_openmpi-4.0.1_openmp_static_opt.sh
Outdated
Show resolved
Hide resolved
|
This might be a good time to consider the start of some unit testing for this |
|
@e10harvey, can you please change the target branch from 'master' to 'develop'? |
Never mind. GitHub let me do it. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: e10harvey |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: e10harvey |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
bartlettroscoe
added
ATDM DevOps
e10harvey
force-pushed
the
atdv-367-cts1empire
branch
from
380045f to
d339119
Compare
e10harvey
force-pushed
the
atdv-367-cts1empire
branch
from
d339119 to
6cbdc80
Compare
e10harvey
added
the
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: e10harvey |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
trilinos-autotester
removed
the
AT: RETEST
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
e10harvey
added a commit
that referenced
this pull request
Jun 11, 2020
|
@bartlettroscoe: Full Trilinos builds and tests passed this morning. See cdash. |
|
Testing this on a few systems: CEE RHEL7 ('ews00323') [PASSED] CTS-1 ('eclipse') [PASSED] |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
e10harvey
added
the
AT: AUTOMERGE
bartlettroscoe
approved these changes
Jun 13, 2020
There was a problem hiding this comment.
Thanks for adding these new unit tests. Now it will be easy to add unit tests for the other systems with this foundation.
This can be done in a latter commit but generally:
- I like to have a 1-to-1 correspondence between a file defining functional code
<functional_code>.shand the unit tests for that code<functional_code>_unit_tests.sh. \ - Personally, like to keep the unit tests in a different directory from the production code. And if you look, there is a separate directory already with the other unit tests which is
cmake/std/atdm/test/unit_tests/. That way, it makes it easy to differentiate production code from test code. (And you can run cloc.pl to show production code vs. test code statistics.)
But let's get this merged so that EMPIRE can get a working CTS-1 build.
| @@ -32,15 +32,18 @@ source ${ATDM_CONFIG_SCRIPT_DIR}/utils/get_system_info_utils.sh | |||
|
|
|||
| realHostname=`hostname` | |||
| if [[ "${ATDM_CONFIG_GET_KNOW_SYSTEM_INFO_REAL_HOSTNAME_OVERRIDE_FOR_UNIT_TESTING}" ]] ; then | |||
There was a problem hiding this comment.
We should play it safe and set hostNameOverride=false here? before this if-statement? Otherwise, it could put up 'hostNameOverride=true' from a previous running.
Comment on lines
+44
to
+45
|
|
||
| ) |
There was a problem hiding this comment.
My preference is to put the closing ) in line with the start of the last element so:
ATDM_KNOWN_SYSTEM_NAMES_LIST=(
dne-name1
dne-name2
dne-name3
)
I think that makes sense when you have nested data-structures.
Comment on lines
+32
to
+37
| # Check that all known system names pass | ||
| for ATDM_CONFIG_BUILD_NAME in ${ATDM_KNOWN_SYSTEM_NAMES_LIST[@]}; do | ||
| ATDM_CONFIG_GET_KNOW_SYSTEM_INFO_REAL_HOSTNAME_OVERRIDE_FOR_UNIT_TESTING=$ATDM_CONFIG_BUILD_NAME | ||
| RET=$(source ${ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO}) | ||
| assertEquals "Hostname '$ATDM_CONFIG_BUILD_NAME' matches known ATDM host '$ATDM_CONFIG_BUILD_NAME' and system '$ATDM_CONFIG_BUILD_NAME'" "$RET" | ||
| done |
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 7518: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
e10harvey
added a commit
to e10harvey/Trilinos
that referenced
this pull request
Jun 15, 2020
- Move unit tests in utils to test/unit_tests. - Ensure the hostNameOverride is not stale. - Split util_unit_tests.sh into separate files.
e10harvey
added a commit
to e10harvey/Trilinos
that referenced
this pull request
Jun 15, 2020
- Move unit tests in utils to test/unit_tests. - Ensure the hostNameOverride is not stale. - Split util_unit_tests.sh into separate files.
trilinos-autotester
added a commit
that referenced
this pull request
Jun 15, 2020
…feedback Automatically Merged using Trilinos Pull Request AutoTester PR Title: ATDM: Implement feedback from #7518 PR Author: e10harvey
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Jun 16, 2020
…s:develop' (8ca364d). * trilinos-develop: Intrepid2: ensure that various derived basis classes have unique names returned by getName(). (trilinos#7529) Summary: ATDM: Implement feedback from trilinos#7518 Piro: rename the space of the multipliers Thyra: rename the directions used in the Hessian vector products and the space of the multipliers Update ninja to 1.10.0 Move to CMake 3.17.1 Thyra: remove get_f_dual_space() from Tempus and Rythmos Thyra: rename Delta_x to delta_x and Delta_p to delta_p Thyra: remove the default implementation of the member functions related to the Hessian from Thyra_ModelEvaluator.hpp Thyra: Add Hessian Objects to ME Set Werror globally for 8.3
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Jun 16, 2020
…s:develop' (8ca364d). * trilinos-develop: Intrepid2: ensure that various derived basis classes have unique names returned by getName(). (trilinos#7529) Summary: ATDM: Implement feedback from trilinos#7518 Piro: rename the space of the multipliers Thyra: rename the directions used in the Hessian vector products and the space of the multipliers Update ninja to 1.10.0 Move to CMake 3.17.1 Thyra: remove get_f_dual_space() from Tempus and Rythmos Thyra: rename Delta_x to delta_x and Delta_p to delta_p Thyra: remove the default implementation of the member functions related to the Hessian from Thyra_ModelEvaluator.hpp Thyra: Add Hessian Objects to ME Set Werror globally for 8.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How was this tested?
See atdv-367.