Skip to content

Commit

Permalink
Merge 'trilinos/Trilinos:develop' (81c48c3) into 'tcad-charon/Trilino…
Browse files Browse the repository at this point in the history
…s:develop' (8ca364d).

* trilinos-develop:
  Intrepid2: ensure that various derived basis classes have unique names returned by getName(). (trilinos#7529)
  Summary:
  ATDM: Implement feedback from trilinos#7518
  Piro: rename the space of the multipliers
  Thyra: rename the directions used in the Hessian vector products and the space of the multipliers
  Update ninja to 1.10.0
  Move to CMake 3.17.1
  Thyra: remove get_f_dual_space() from Tempus and Rythmos
  Thyra: rename Delta_x to delta_x and Delta_p to delta_p
  Thyra: remove the default implementation of the member functions related to the Hessian from Thyra_ModelEvaluator.hpp
  Thyra: Add Hessian Objects to ME
  Set Werror globally for 8.3
  • Loading branch information
Jenkins Pipeline committed Jun 16, 2020
2 parents 8ca364d + 81c48c3 commit 9aa1c0f
Show file tree
Hide file tree
Showing 59 changed files with 4,341 additions and 854 deletions.
6 changes: 3 additions & 3 deletions cmake/std/PullRequestLinuxDriverTest.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,9 @@ def setBuildEnviron(arguments):
'sems-parmetis/4.0.3/parallel',
'sems-scotch/6.0.3/nopthread_64bit_parallel',
'sems-superlu/4.3/base',
'sems-cmake/3.10.3',
'atdm-env',
'atdm-ninja_fortran/1.7.2'],
'sems-cmake/3.17.1',
'sems-ninja_fortran/1.10.0',
'atdm-env'],
'Trilinos_pullrequest_intel_17.0.1':
['sems-env',
'sems-git/2.10.1',
Expand Down
56 changes: 1 addition & 55 deletions cmake/std/PullRequestLinuxGCC8.3.0TestingSettings.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -28,58 +28,4 @@ set (Teko_DISABLE_LSCSTABALIZED_TPETRA_ALPAH_INV_D ON CACHE BOOL "Temporarily di

include("${CMAKE_CURRENT_LIST_DIR}/PullRequestLinuxCommonTestingSettings.cmake")

set(CMAKE_CXX_FLAGS "-std=c++14 -fno-strict-aliasing -Wall -Wno-clobbered -Wno-vla -Wno-pragmas -Wno-unknown-pragmas -Wno-parentheses -Wno-unused-local-typedefs -Wno-literal-suffix -Wno-deprecated-declarations -Wno-misleading-indentation -Wno-int-in-bool-context -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-inline -Wno-nonnull-compare -Wno-address -DTRILINOS_HIDE_DEPRECATED_HEADER_WARNINGS" CACHE STRING "Warnings as errors settings")

set (Amesos_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Amesos2_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Anasazi_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (AztecOO_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Belos_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Domi_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Epetra_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (EpetraExt_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (FEI_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Galeri_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (GlobiPack_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Gtest_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Ifpack_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Ifpack2_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Intrepid_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Intrepid2_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Isorropia_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Kokkos_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (KokkosKernels_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (MiniTensor_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (ML_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (MueLu_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (NOX_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (OptiPack_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Pamgen_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Panzer_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Phalanx_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Pike_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Piro_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (ROL_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (RTOp_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Rythmos_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Sacado_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
#set (SEACAS_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Shards_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (ShyLU_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (ShyLU_DD_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (ShyLU_Node_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (STK_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Stokhos_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Stratimikos_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Teko_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Tempus_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Teuchos_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (ThreadPool_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Thyra_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Tpetra_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (TrilinosCouplings_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (TrilinosSS_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Triutils_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Xpetra_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Zoltan_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set (Zoltan2_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" CACHE STRING "Warnings as errors setting")
set(CMAKE_CXX_FLAGS "-std=c++14 -fno-strict-aliasing -Wall -Wno-clobbered -Wno-vla -Wno-pragmas -Wno-unknown-pragmas -Wno-parentheses -Wno-unused-local-typedefs -Wno-literal-suffix -Wno-deprecated-declarations -Wno-misleading-indentation -Wno-int-in-bool-context -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-inline -Wno-nonnull-compare -Wno-address -DTRILINOS_HIDE_DEPRECATED_HEADER_WARNINGS -Werror" CACHE STRING "Warnings as errors settings")
1 change: 0 additions & 1 deletion cmake/std/atdm/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ TRIBITS_ADD_TEST_DIRECTORIES(van1-tx2)
TRIBITS_ADD_TEST_DIRECTORIES(ats1)
TRIBITS_ADD_TEST_DIRECTORIES(ats2)
TRIBITS_ADD_TEST_DIRECTORIES(cts1)
TRIBITS_ADD_TEST_DIRECTORIES(utils)
TRIBITS_PACKAGE_POSTPROCESS()
22 changes: 22 additions & 0 deletions cmake/std/atdm/test/unit_tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,25 @@ TRIBITS_ADD_ADVANCED_TEST( set_build_options_unit_tests
PASS_REGULAR_EXPRESSION_ALL "Ran 13 test" "[^]OK[$]"
ALWAYS_FAIL_ON_NONZERO_RETURN
)

TRIBITS_ADD_ADVANCED_TEST( atdm_config_helper_funcs_unit_tests
OVERALL_WORKING_DIRECTORY TEST_NAME
OVERALL_NUM_MPI_PROCS 1
TEST_0 CMND env
ARGS SHUNIT_COLOR=none ${CMAKE_CURRENT_SOURCE_DIR}/atdm_config_helper_funcs_unit_test.sh
PASS_REGULAR_EXPRESSION_ALL
"Ran 1 test"
"[^]OK[$]"
ALWAYS_FAIL_ON_NONZERO_RETURN
)

TRIBITS_ADD_ADVANCED_TEST( get_known_system_info_unit_tests
OVERALL_WORKING_DIRECTORY TEST_NAME
OVERALL_NUM_MPI_PROCS 1
TEST_0 CMND env
ARGS SHUNIT_COLOR=none ${CMAKE_CURRENT_SOURCE_DIR}/get_known_system_info_unit_test.sh
PASS_REGULAR_EXPRESSION_ALL
"Ran 1 test"
"[^]OK[$]"
ALWAYS_FAIL_ON_NONZERO_RETURN
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
#!/bin/bash

CURRENT_SCRIPTS_DIR=`echo $BASH_SOURCE | sed "s/\(.*\)\/.*\.sh/\1/g"`

if [[ "$(uname)" == "Darwin" ]]; then
ATDM_CONFIG_SCRIPT_DIR="../.."
ATDM_UTIL_SCRIPT_ATDM_CONFIG_HELPER_FUNCS="${ATDM_CONFIG_SCRIPT_DIR}/utils/atdm_config_helper_funcs.sh"
SHUNIT2_DIR="${ATDM_CONFIG_SCRIPT_DIR}/../../../commonTools/test/shunit2"
else
ATDM_CONFIG_SCRIPT_DIR=`readlink -f ${CURRENT_SCRIPTS_DIR}/../..`
ATDM_UTIL_SCRIPT_ATDM_CONFIG_HELPER_FUNCS=`readlink -f ${ATDM_CONFIG_SCRIPT_DIR}/utils/atdm_config_helper_funcs.sh`
SHUNIT2_DIR=`readlink -f ${ATDM_CONFIG_SCRIPT_DIR}/../../../commonTools/test/shunit2`
fi

source ${ATDM_UTIL_SCRIPT_ATDM_CONFIG_HELPER_FUNCS}
#
# Test atdm utility functions
#

test_atdm_remove_substrings_from_env_var() {
for DELIM in ":" "," "-" "_"; do
# Don't remove anything from path
EXPECTED_ENV_VAR="/paths"
ENV_VAR="$EXPECTED_ENV_VAR"
STRINGS="/test/path1"
atdm_remove_substrings_from_env_var ENV_VAR "$DELIM" "$STRINGS"
${_ASSERT_EQUALS_} ${EXPECTED_ENV_VAR} ${ENV_VAR}

# Remove dir from end of path
EXPECTED_ENV_VAR="/paths"
ENV_VAR="$EXPECTED_ENV_VAR$DELIM/test/path1"
STRINGS="/test/path1"
atdm_remove_substrings_from_env_var ENV_VAR "$DELIM" "$STRINGS"
${_ASSERT_EQUALS_} ${EXPECTED_ENV_VAR} ${ENV_VAR}

# Remove dir at beginning of path
EXPECTED_ENV_VAR="/paths"
ENV_VAR="/test/path1$DELIM$EXPECTED_ENV_VAR"
STRINGS="/test/path1"
atdm_remove_substrings_from_env_var ENV_VAR "$DELIM" "$STRINGS"
${_ASSERT_EQUALS_} ${EXPECTED_ENV_VAR} ${ENV_VAR}

# Remove dir at beginning of path with similar path beside it
EXPECTED_ENV_VAR="/paths$DELIM/paths2"
ENV_VAR="/test/path1$DELIM$EXPECTED_ENV_VAR"
STRINGS="/test/path1"
atdm_remove_substrings_from_env_var ENV_VAR "$DELIM" "$STRINGS"
${_ASSERT_EQUALS_} ${EXPECTED_ENV_VAR} ${ENV_VAR}

# Remove dirs at beginning and end of path
EXPECTED_ENV_VAR="/paths"
ENV_VAR="/test/path1$DELIM$EXPECTED_ENV_VAR$DELIM/test/path2"
STRINGS="/test/path1 /test/path2"
atdm_remove_substrings_from_env_var ENV_VAR "$DELIM" "$STRINGS"
${_ASSERT_EQUALS_} ${EXPECTED_ENV_VAR} ${ENV_VAR}

# Only one dir matches to be removed (other non-matching dir is ignored)
EXPECTED_ENV_VAR="/paths"
ENV_VAR="/test/path2$DELIM/test/path1$DELIM$EXPECTED_ENV_VAR"
STRINGS="/test/path1 /test/path2"
atdm_remove_substrings_from_env_var ENV_VAR "$DELIM" "$STRINGS"
${_ASSERT_EQUALS_} ${EXPECTED_ENV_VAR} ${ENV_VAR}
done

for DELIM in ";" "." "/" " "; do
RET=$(atdm_remove_substrings_from_env_var ENV_VAR "$DELIM" "$STRINGS")
assertEquals "ERROR: atdm_remove_substrings_from_env_var: \"$DELIM\" is an invalid delimiter." "$RET"
done
}

#
# Run the unit tests
#
. ${SHUNIT2_DIR}/shunit2
70 changes: 70 additions & 0 deletions cmake/std/atdm/test/unit_tests/get_known_system_info_unit_test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
#!/bin/bash

CURRENT_SCRIPTS_DIR=`echo $BASH_SOURCE | sed "s/\(.*\)\/.*\.sh/\1/g"`

if [[ "$(uname)" == "Darwin" ]]; then
ATDM_CONFIG_SCRIPT_DIR="../.."
ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO="${ATDM_CONFIG_SCRIPT_DIR}/utils/get_known_system_info.sh"
SHUNIT2_DIR="${ATDM_CONFIG_SCRIPT_DIR}/../../../commonTools/test/shunit2"
else
ATDM_CONFIG_SCRIPT_DIR=`readlink -f ${CURRENT_SCRIPTS_DIR}/../..`
ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO=`readlink -f ${ATDM_CONFIG_SCRIPT_DIR}/utils/get_known_system_info.sh`
SHUNIT2_DIR=`readlink -f ${ATDM_CONFIG_SCRIPT_DIR}/../../../commonTools/test/shunit2`
fi

#
# Test atdm get_known_system_info script
#
test_atdm_get_known_system_info() {
# TODO: D.2 needs to be tested by setting these values:
SNLSYSTEM=
SEMS_PLATFORM=
ATDM_SYSTEM_NAME=
SNLCLUSTER=

# Get the good ATDM_KNOWN_SYSTEM_NAMES_LIST
ATDM_CONFIG_BUILD_NAME=unit_test
ATDM_CONFIG_DISABLE_WARNINGS=ON
source ${ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO}

# Check that all known system names pass
for ATDM_CONFIG_BUILD_NAME in ${ATDM_KNOWN_SYSTEM_NAMES_LIST[@]}; do
ATDM_CONFIG_GET_KNOW_SYSTEM_INFO_REAL_HOSTNAME_OVERRIDE_FOR_UNIT_TESTING=$ATDM_CONFIG_BUILD_NAME
RET=$(source ${ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO})
assertEquals "Hostname '$ATDM_CONFIG_BUILD_NAME' matches known ATDM host '$ATDM_CONFIG_BUILD_NAME' and system '$ATDM_CONFIG_BUILD_NAME'" "$RET"
done

# Set the bad ATDM_KNOWN_SYSTEM_NAMES
ATDM_KNOWN_SYSTEM_NAMES_LIST=(
dne-name1
dne-name2
dne-name3
)

# Check a few bad systems names for failure
for ATDM_CONFIG_BUILD_NAME in ${ATDM_KNOWN_SYSTEM_NAMES_LIST[@]}; do
ATDM_CONFIG_GET_KNOW_SYSTEM_INFO_REAL_HOSTNAME_OVERRIDE_FOR_UNIT_TESTING=$ATDM_CONFIG_BUILD_NAME
source ${ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO}
assertEquals "" "$ATDM_SYSTEM_NAME"
assertEquals "$ATDM_CONFIG_BUILD_NAME" "$realHostname"
done

# Ensure that cts1empire is the default on cts1
ATDM_CONFIG_BUILD_NAME=default
ATDM_CONFIG_GET_KNOW_SYSTEM_INFO_REAL_HOSTNAME_OVERRIDE_FOR_UNIT_TESTING=$ATDM_CONFIG_BUILD_NAME
SNLSYSTEM=cts1
RET=$(source ${ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO})
assertEquals "Hostname '$ATDM_CONFIG_BUILD_NAME' matches known ATDM host '$ATDM_CONFIG_BUILD_NAME' and system 'cts1empire'" "$RET"

# Ensure that cts1 is still selected when it's in the build name
ATDM_CONFIG_BUILD_NAME=cts1-default
ATDM_CONFIG_GET_KNOW_SYSTEM_INFO_REAL_HOSTNAME_OVERRIDE_FOR_UNIT_TESTING=$ATDM_CONFIG_BUILD_NAME
SNLSYSTEM=cts1
RET=$(source ${ATDM_UTIL_SCRIPT_GET_KNOWN_SYSTEM_INFO})
assertEquals "Hostname '$ATDM_CONFIG_BUILD_NAME' matches known ATDM host '$ATDM_CONFIG_BUILD_NAME' and system 'cts1'" "$RET"
}

#
# Run the unit tests
#
. ${SHUNIT2_DIR}/shunit2
10 changes: 0 additions & 10 deletions cmake/std/atdm/utils/CMakeLists.txt

This file was deleted.

1 change: 1 addition & 0 deletions cmake/std/atdm/utils/get_known_system_info.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ fi
source ${ATDM_CONFIG_SCRIPT_DIR}/utils/get_system_info_utils.sh

realHostname=`hostname`
hostNameOverride=false
if [[ "${ATDM_CONFIG_GET_KNOW_SYSTEM_INFO_REAL_HOSTNAME_OVERRIDE_FOR_UNIT_TESTING}" ]] ; then
if [[ -z $ATDM_CONFIG_DISABLE_WARNINGS ]]; then
echo
Expand Down
129 changes: 0 additions & 129 deletions cmake/std/atdm/utils/util_unit_tests.sh

This file was deleted.

Loading

0 comments on commit 9aa1c0f

Please sign in to comment.