Tpetra,Teuchos: Fix #3057 #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 3, 2018 15:47
@trilinos/tpetra @trilinos/teuchos Tpetra::Map was and still is responsible for initializing Kokkos, if the user hasn't done it already. This commit moves the initialization code out of Teuchos into Tpetra. It also removes the dependency on std::call_once. It appears that with GCC, std::call_once only works if linking with libpthread. Thus, setting TPL_ENABLE_Pthread=OFF (which we don't recommend -- Trilinos autodetects this) could break std::call_once. This change could break a possible use case in which Kokkos::initialize has not been called, and different user threads each create different Tpetra::Map instances. However, Trilinos does not test this use case, nor do the applications we support appear to exercise it. I also took the liberty to purge some unnecessary header includes.
ibaned
approved these changes
Jul 3, 2018
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Using Repos:
Pull Request Author: mhoemmen |
kddevin
approved these changes
Jul 3, 2018
mhoemmen
added
pkg: Tpetra
pkg: Teuchos
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ kddevin ibaned ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra @trilinos/teuchos
Description
Tpetra::Mapwas and still is responsible for initializing Kokkos, if the user hasn't done it already. This pull request moves the initialization code out of Teuchos into Tpetra. It also removes the dependency onstd::call_once. It appears that with GCC,std::call_onceonly works if linking with libpthread. Thus, settingTPL_ENABLE_Pthread=OFF(which we don't recommend -- Trilinos autodetects this) could breakstd::call_once.This change could break a possible use case in which
Kokkos::initializehas not been called, and different user threads each create differentTpetra::Mapinstances. However, Trilinos does not test this use case, nor do the applications we support appear to exercise it.I also took the liberty to purge some unnecessary header includes and fix some shadowing warnings.
The commit refers to #3033, because I wrote the commit message before #3057 superseded it.
Motivation and Context
This aligns with #57 and the general push to deprecate and remove Node in Tpetra, in favor of
device_type = Kokkos::Device.Related Issues
How Has This Been Tested?
Locally, with OpenMP enabled.
Checklist