Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: Make it possible to use a Kokkos::Device or Kokkos execution space in place of Node #505

Closed
mhoemmen opened this issue Jul 20, 2016 · 3 comments
Assignees
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Tpetra TpetraRF

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Jul 20, 2016

@trilinos/tpetra
#57 depends on this.

  1. Move Tpetra objects into an inner, hidden namespace.
  2. Use C++11 type aliases in the Tpetra namespace, so supplying a Kokkos::Device or Kokkos execution space in place of the Node works

For example (default template parameters omitted for brevity):

namespace Tpetra {
namespace Impl {
template<class S, class LO, class GO, class Node> 
class MultiVector { /* the actual implementation */ };
} // namespace Impl

template<class S, class LO, class GO, class ExecSpace, class MemSpace>
using MultiVector = Impl::MultiVector<S, LO, GO, Kokkos::Compat::KokkosDeviceWrapperNode<ExecSpace, MemSpace> >;

} // namespace Tpetra
@mhoemmen mhoemmen added this to the Tpetra: Replace Node with Kokkos space milestone Jul 20, 2016
@mhoemmen mhoemmen self-assigned this Jul 20, 2016
@mhoemmen mhoemmen added story The issue corresponds to a Kanban Story (vs. Epic or Task) task and removed story The issue corresponds to a Kanban Story (vs. Epic or Task) labels Sep 16, 2016
@mhoemmen
Copy link
Contributor Author

This is a "task" because it's well defined and could be done by one person. However, please note specializations of Tpetra::MultiVector in Stokhos (and Sacado too?). Those must also be fixed.

@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jan 17, 2021
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Feb 17, 2021
bartlettroscoe added a commit that referenced this issue Jul 30, 2022
Origin repo remote tracking branch: 'github/master'
Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git'
Git describe: Vera4.0-RC1-start-1228-g15992142

At commit:

commit 9fc3c95d46d78845b3bf24afd89e0756c19e6d2d
Author:  Roscoe A. Bartlett <rabartl@sandia.gov>
Date:    Thu Jul 28 11:42:10 2022 -0600
Summary: Remove GLOBAL from TPL IMPORTED targets, use if (NOT TARGET <upstreamTpl>::all_libs) (#505)
@jhux2 jhux2 added this to Tpetra Aug 12, 2024
@jhux2 jhux2 moved this to Done in Tpetra Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Tpetra TpetraRF
Projects
Status: Done
Development

No branches or pull requests

2 participants