WIP: V1.1.1 #103
Merged
WIP: V1.1.1 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* {vdiffr} v1.0.6 has new device name
which means {gridpattern} v1.1.0 can now
always distinguish between `svglite::svglite()`
and `vdiffr:::svglite()`
* Each pattern aesthetic may now be a list of vectors with each list element providing that aesthetic for a different pattern (#100). Most builtin `{gridpattern}` "geometry" patterns support multiple fill colors etc. which previously we could only access in `{ggpattern}` via custom patterns. * We remove the multi-color stripe custom pattern example from developing patterns vignette. With this update we don't need a custom serialization pattern anymore to have multi-color stripe patterns. closes #100
* Trailing newlines/tests in files in `R` directory
have been deleted.
* Do note every geom with a test in a `FALSE` block in `R`
now has a test in the `tests` directory run by
`{testthat}`.
* `draw_key_boxplot_pattern()`, `draw_key_crossbar_pattern()`, and `draw_key_polygon_pattern()` `aspect_ratio` argument
now defaults to `get_aspect_ratio()`.
* `create_pattern_grobs()` `aspect_ratio` argument now defaults to `get_aspect_ratio()`
* `aspect_ratio` elements in ggproto Geom objects have been removed.
* These changes should make it easier to update geoms to match upstream
changes in `{ggplot2}`.
BREAKING CHANGES:
* The `draw_key_polygon_pattern()` called by `geom_sf_pattern()` is now passed in its
actual aspect ratio (instead of 1).
This may cause your legends to `geom_sf_pattern()` to look different.
* But also mention that it omits several vignettes. progress on #98 [skip ci]
* `geom_bin_2d_pattern()` is now an alias for `geom_bin2d_pattern()`.
This matches `{ggplot2}` which has both `geom_bin_2d()` and `geom_bin2d()`.
* We also place `geom_histogram_pattern()` in `geom-histogram.R`
to better match the file structure in `{ggplot2}` to make it easier
to scan for the differences we maintain.
* We currently "import" ggplot2 so not necessary.
* Trying to minimize differences between the `{ggplot2}` 3.4.3
codebase and that of our geoms when glanced at with a diffing tool...
* {ggplot2} v3.5 deprecated `scale_name` in `binned_scale()`,
`continuous_scale()`, and `discrete_scale()`.
* We bump the {ggplot2} version in DESCRIPTION to (>= 3.5.0)
and remove all deprecated `scale_name`.
* Regenerate image * Set `fig.cap = ""` to remove "unnamed plot chunk" caption * Remove TODO section (which we track in Github Issues) * Fix typo closes #110
* Github repo moved from `coolbutuseless/ggpattern` to `trevorld/ggpattern`
* {pkgdown} website moved to https://trevorldavis.com/R/ggpattern/dev/
* Trevor L. Davis (@trevorld) has been the maintainer of `ggpattern`
for a few years now.
closes #98
* The `fill` and `pattern_fill` aesthetics may now be (a list of) gradient/pattern fills (in addition to color strings) (#112). Note using gradient/pattern fills will require R (>= 4.2) and a graphics device with support for the gradient/pattern fill feature. Use of just color fills should continue to work on a wider variety of R versions and graphics devices. closes #112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gridpattern::reset_image_cache()in image vignette{vdiffr}and{gridpattern}versionsproviding that aesthetic for a different pattern (Allow
pattern_fill(and more) to take a **list** of (color) vectors #100).Most builtin
{gridpattern}"geometry" patterns support multiple fill colors etc. which previously we could only access in{ggpattern}via custom patterns.patterns vignette. With this update we don't need a custom serialization pattern anymore to have multi-color stripe patterns.
geom_bin_2d_pattern()as an alias forgeom_bin2d_pattern()progress on #104
closes #95, closes #98, closes #100, closes #106, closes #110, closes #112