Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent exposure of linejoin and lineend parameters #94

Closed
Tracked by #104
trevorld opened this issue Jan 31, 2023 · 0 comments · Fixed by #118
Closed
Tracked by #104

Consistent exposure of linejoin and lineend parameters #94

trevorld opened this issue Jan 31, 2023 · 0 comments · Fixed by #118
Assignees
Labels
enhancement New feature or request

Comments

@trevorld
Copy link
Owner

@trevorld trevorld added the enhancement New feature or request label Jan 31, 2023
@trevorld trevorld mentioned this issue Oct 4, 2023
23 tasks
@trevorld trevorld self-assigned this Oct 4, 2023
trevorld added a commit that referenced this issue Apr 24, 2024
* Internal geom code has been updated to more closely match ggplot2 v3.5.1
  equivalents when viewed with vimdiff algorithms
* Geoms now more consistently expose the `lineend` and `linejoin` parameters.
  This matches a similar upstream change in ggplot2 3.4.0.
* `geom_area_pattern()` and `geom_ribbon_pattern()` now accept `outline.type = "lower"` and `outline.type = "full"`.
  `geom_density_pattern()` now exposes the `outline.type` parameter.
* `geom_boxplot_pattern()` now accept the `outliers` and `staplewidth` parameters.
  The `outliers` and `staplewidth` parameters were added to `geom_boxplot()` in ggplot2 3.5.0.
* `geom_sf_pattern()` now accepts the `arrow` parameter.
  The `arrow` parameter was added to `geom_sf()` in ggplot2 3.5.0.
* `geom_violin_pattern()` now accepts the `bounds` parameter.
  The `bounds` parameter was added to `geom_violin()` in ggplot2 3.5.0.

BREAKING CHANGES:

* `outline.type = "legacy"` has been removed in
  `geom_area_pattern()` and `geom_ribbon_pattern()`.
  `outline.type = "legacy"` was deprecated with ggpattern 0.1.0 (2020-04-01).

closes #94
trevorld added a commit that referenced this issue Apr 27, 2024
* Internal geom code has been updated to more closely match ggplot2 v3.5.1
  equivalents when viewed with vimdiff algorithms
* Geoms now more consistently expose the `lineend` and `linejoin` parameters.
  This matches a similar upstream change in ggplot2 3.4.0.
* `geom_area_pattern()` and `geom_ribbon_pattern()` now accept `outline.type = "lower"` and `outline.type = "full"`.
  `geom_density_pattern()` now exposes the `outline.type` parameter.
* `geom_boxplot_pattern()` now accept the `outliers` and `staplewidth` parameters.
  The `outliers` and `staplewidth` parameters were added to `geom_boxplot()` in ggplot2 3.5.0.
* `geom_sf_pattern()` now accepts the `arrow` parameter.
  The `arrow` parameter was added to `geom_sf()` in ggplot2 3.5.0.
* `geom_violin_pattern()` now accepts the `bounds` parameter.
  The `bounds` parameter was added to `geom_violin()` in ggplot2 3.5.0.

DEPRECATED FEATURES:

* `outline.type = "legacy"` is now formally deprecated in
  `geom_area_pattern()` and `geom_ribbon_pattern()`.
  Use `outline.type = "full"` instead.
  `outline.type = "legacy"` was deprecated with ggpattern 0.1.0 (2020-04-01)
  but this is the first time `outline.type = "full"` has been supported as an alternative.

closes #94
trevorld added a commit that referenced this issue Apr 27, 2024
* Internal geom code has been updated to more closely match ggplot2 v3.5.1
  equivalents when viewed with vimdiff algorithms
* Geoms now more consistently expose the `lineend` and `linejoin` parameters.
  This matches a similar upstream change in ggplot2 3.4.0.
* `geom_area_pattern()` and `geom_ribbon_pattern()` now accept `outline.type = "lower"` and `outline.type = "full"`.
  `geom_density_pattern()` now exposes the `outline.type` parameter.
* `geom_boxplot_pattern()` now accept the `outliers` and `staplewidth` parameters.
  The `outliers` and `staplewidth` parameters were added to `geom_boxplot()` in ggplot2 3.5.0.
* `geom_sf_pattern()` now accepts the `arrow` parameter.
  The `arrow` parameter was added to `geom_sf()` in ggplot2 3.5.0.
* `geom_violin_pattern()` now accepts the `bounds` parameter.
  The `bounds` parameter was added to `geom_violin()` in ggplot2 3.5.0.

DEPRECATED FEATURES:

* `outline.type = "legacy"` is now formally deprecated in
  `geom_area_pattern()` and `geom_ribbon_pattern()`.
  Use `outline.type = "full"` instead.
  `outline.type = "legacy"` was deprecated with ggpattern 0.1.0 (2020-04-01)
  but this is the first time `outline.type = "full"` has been supported as an alternative.

closes #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant