Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure using expression has a valid type #295

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

travisbrown
Copy link
Owner

Right now the implementation silently ignores records with extra fields in using, or even ill-typed expressions, but the standard says the expression must have one of two types:

(Δ, parent) × Γ₀ ⊢ requestHeaders ⇒ resolvedRequestHeaders ⊢ Γ₁
ε ⊢ resolvedRequestHeaders : H
H ∈ { List { mapKey : Text, mapValue : Text }, List { header : Text, value : Text } }

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #295 (e84a798) into main (624a37b) will increase coverage by 0.57%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   58.22%   58.80%   +0.57%     
==========================================
  Files          30       30              
  Lines         936      954      +18     
  Branches       54       61       +7     
==========================================
+ Hits          545      561      +16     
- Misses        391      393       +2     
Impacted Files Coverage Δ
.../src/main/scala/org/dhallj/imports/ToHeaders.scala 86.95% <90.69%> (+1.24%) ⬆️
...ala/org/dhallj/imports/ResolveImportsVisitor.scala 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624a37b...e84a798. Read the comment docs.

@travisbrown travisbrown merged commit 0555246 into main Jul 28, 2021
@travisbrown travisbrown deleted the topic/type-check-headers branch July 28, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants