Check double bounds while parsing (#294)

travisbrown · Jul 28, 2021 · 624a37b · 624a37b
1 parent 1bb0361
commit 624a37b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/modules/core/src/main/java/org/dhallj/core/DhallException.java b/modules/core/src/main/java/org/dhallj/core/DhallException.java
@@ -21,6 +21,10 @@ public Throwable fillInStackTrace() {
     public ParsingFailure(String message, Throwable cause) {
       super(message, cause);
     }
+
+    public ParsingFailure(String message) {
+      super(message);
+    }
   }
 
   public static final class ResolutionFailure extends DhallException {

diff --git a/modules/parser/src/main/java/org/dhallj/parser/support/ParsingHelpers.java b/modules/parser/src/main/java/org/dhallj/parser/support/ParsingHelpers.java
@@ -26,8 +26,15 @@ private static Source sourceFromToken(Token token) {
   }
 
   static final Expr.Parsed makeDoubleLiteral(Token token) {
-    return new Expr.Parsed(
-        Expr.makeDoubleLiteral(Double.parseDouble(token.image)), sourceFromToken(token));
+    double parsed = Double.parseDouble(token.image);
+
+    if (Double.isInfinite(parsed)
+        && !token.image.equals("Infinity")
+        && !token.image.equals("-Infinity")) {
+      throw new ParsingFailure("double out of bounds");
+    }
+
+    return new Expr.Parsed(Expr.makeDoubleLiteral(parsed), sourceFromToken(token));
   }
 
   static final Expr.Parsed makeNaturalLiteral(Token token) {